-
Notifications
You must be signed in to change notification settings - Fork 197
prompt(core): add cluster health check #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Output format: ===============================================
|
2e02dc9 to
767c1db
Compare
|
I'm not really sure about this one, it seems to be quite opinionated. In https://github.com/Flux159/mcp-server-kubernetes they're implementing similar functionality via a prompt. Which doesn't seem like a bad idea. Similarly, in https://github.com/GoogleCloudPlatform/kubectl-ai (AFAIU) they're leveraging the system prompt for this purpose: https://github.com/GoogleCloudPlatform/kubectl-ai/blob/main/pkg/agent/systemprompt_template_default.txt IMO if we want to proceed with this feature we should either:
This is also a good case to test evals and see if they can be used to make a better decision on how to implement this feature. |
5fd5987 to
afb7d63
Compare
|
Hi @manusa/@matzew Updated as per suggestions. |
b7fde2e to
8b8c9e9
Compare
manusa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@ropatil010 would be you be able to rebase this PR? thanks |
6a8f524 to
17bda66
Compare
17bda66 to
7a56109
Compare
|
Hi @nader-ziada , i have rebase the PR and updated the files accordingly by using the existing function definitions. |
sorry, you will have to rebase again, but should be a small conflict this time, please see comment, thanks |
Signed-off-by: Rohit Patil <[email protected]>
Signed-off-by: Rohit Patil <[email protected]>
7a56109 to
8302c9f
Compare
|
thanks @ropatil010 |
|
@ropatil010 The |
|
@manusa any comments about this PR? |
Signed-off-by: Rohit Patil <[email protected]>
|
Hi @manusa/@nader-ziada Fixed as per suggestions. Can you PTAL when ever get a chance? |
Hi Team,
Can you PTAL on this.
PR about:
Implements comprehensive cluster health check tool that examines:
Features: