refactor: use ide.readFile instead of fs.readFile in static context service #8422
+12
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
@uinstinct I tried merging main into this branch but we still have a lot of test failures that must be coming from the changes here |
uinstinct
force-pushed
the
static-context-ide-readfile
branch
from
7be374d to
74af332
Compare
tingwai
reviewed
Nov 5, 2025
| if (entry.isDirectory()) { | ||
| // Skip common directories that typically don't contain source files | ||
| if (!shouldSkipDirectory(entry.name)) { | ||
| if (fileType === (2 as FileType.Directory)) { |
Collaborator
There was a problem hiding this comment.
I'm not familiar with the ide API, we're supposed to typecast 2 as FileType.Directory?
Contributor
Author
There was a problem hiding this comment.
Yes, actually FileType enum exists in a .d.ts file which has import issues when not used as a type
we have done this in few places such as:
continue/core/commands/slash/built-in-legacy/onboard.ts
Lines 75 to 76 in 1c1fce3
continue/core/util/filesystem.ts
Lines 110 to 113 in 1c1fce3
tingwai
approved these changes
Nov 6, 2025
Contributor
|
🎉 This PR is included in version 1.32.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use ide.readfile instead of fs.readfile in StaticContextService
resolves CON-4504
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Refactored StaticContextService to use IDE file APIs for reading files and scanning directories, improving support for URIs and virtual workspaces. Addresses CON-4504 by routing file access through the IDE layer.