feat(cohere): add support from Reasoning/Vision/Translate models #8597
Conversation
dosubot
bot
added
the
size:XXL
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 9 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="core/llm/llms/Cohere.ts">
<violation number="1" location="core/llm/llms/Cohere.ts:83">
Wrapping assistant content in a `{type: "text"}` block assigns arrays of `MessagePart`s to the `text` field, corrupting structured assistant replies when they are already multi-part.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| } else { | ||
| msg.content.push({ | ||
| type: "text", | ||
| text: m.content, |
There was a problem hiding this comment.
Wrapping assistant content in a {type: "text"} block assigns arrays of MessageParts to the text field, corrupting structured assistant replies when they are already multi-part.
Prompt for AI agents
Address the following comment on core/llm/llms/Cohere.ts at line 83:
<comment>Wrapping assistant content in a `{type: "text"}` block assigns arrays of `MessagePart`s to the `text` field, corrupting structured assistant replies when they are already multi-part.</comment>
<file context>
@@ -48,36 +47,44 @@ class Cohere extends BaseLLM {
+ } else {
+ msg.content.push({
+ type: "text",
+ text: m.content,
});
- lastToolPlan = undefined;
</file context>
RomneyDa
left a comment
RomneyDa
left a comment
There was a problem hiding this comment.
@maxbrunet appreciate this contribution and thanks for the tests.
Pretty much looks good to me, could you check on the comments briefly including the cubic one? Then should be good to merge
| { | ||
| model: "command-a-translate-08-2025", | ||
| displayName: "Command A Translate 08-2025", | ||
| contextLength: 8000, |
There was a problem hiding this comment.
probably 8192, not critical
| switch (value.type) { | ||
| // https://docs.cohere.com/v2/docs/streaming#content-delta | ||
| case "content-delta": | ||
| if (value.delta.message.content.thinking) { |
There was a problem hiding this comment.
@maxbrunet just to double check can content deltas also have text that would be lost here? or is it thinking OR text?
| } else { | ||
| msg.content.push({ | ||
| type: "text", | ||
| text: m.content, |
2 participants
Description
[ What changed? Feel free to be brief. ]
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Add Cohere Reasoning, Vision, and Translate model support across the provider, UI, and docs. Enables thinking traces, image input, and new models with correct tool-calling behavior and tests.
Written for commit 9525ea8. Summary will update automatically on new commits.