Fix buffer boundary handling in copilot--get-source #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* copilot.el (copilot--get-source): Widen at beginning. Add buffer boundary checks when truncating the buffer content. Ensure that substring operations never exceed buffer limits by clamping to valid ranges.
bbatsov
approved these changes
Jun 22, 2025
Collaborator
bbatsov
left a comment
bbatsov
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some boundary checks, fixing sporadic issues that I
encountered, and also adds a call to "widen" to fix the following
easily reproduced issue: copilot-mode does not work correctly when
activated in an already narrowed buffer.
boundary checks when truncating the buffer content. Ensure that
substring operations never exceed buffer limits by clamping to valid
ranges.