Support distance calculation and limits in address queries #17429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proof-of-concept for distance queries for addresses, as suggested in #17227
The PR adds a
AddressQuery::distanceTo()method to calculate the distance of an address to a given place, limit the query by minimum and/or maximum distance, and order results by distance.Usage:
Definitely more of a proof of concept, there are a couple of things left to do:
distanceTo()functiondistanceproperty will be a float representing the distance in meters, andminandmaxexpect a distance in meters as well. Might want to support both metric and imperial units?distanceproperty into a localized string (similar to themoneyordatefilters) would be helpful.queryandsubQuery? I don't completely understand this, but in my testing, adding the conditions only to the main query resulted in incorrect results, especially with pagination.Related issues
#17227