-
Notifications
You must be signed in to change notification settings - Fork 680
Initial inertia rendering #18005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.x
Are you sure you want to change the base?
Initial inertia rendering #18005
Conversation
Not final UI, focusing on functionality over form at this point
…nto feature/inertia-dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit tempted to replace this with TanStack Query but I'm also a bit wary of hitching ourselves to that bandwagon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found that in general axios/fetch requests are barely necessary when using Inertia as intended and for the few cases where they're needed fetch is enough.
As soon as there's something that's clicked or interacted with by the user for the action you either create a link (even if it's a POST or DELETE) or a form.
Especially since it makes it possible to do partial reloads
When I started this, I thought, "I'll do the dashboard, that's not too complicated.". Guess what world? I was wrong. Turns out there's a lot of functionality packed into our little dashboard.
Even though this PR isn't finished, I wanted to open it to start getting feedback on the direction things are heading.
The general plan is to use Inertia with Vue to handle the rendering of the CP. The Vue pages will then render our web components from the
@craftcms/cppackage (#18010). General layout will be handled by Tailwind utility classes.All these together will hopefully help usher in a new era free from the quantum entanglement we find ourselves in with the current CSS.
Even though this PR is large already, there's still a good list of things that need to be tackled before we'll reach feature parity with the current Dashboard.
To-Do
settingsJsmay need to be evaluated when creating a widgetSlidePickercomponents