Skip to content

Conversation

@nobodywasishere
Copy link
Member

Closes #69, #39

@nobodywasishere nobodywasishere requested a review from keidax June 28, 2025 08:07
@keidax
Copy link
Collaborator

keidax commented Jul 7, 2025

I'm surprised at how much this balloons the parser size 😳
Any idea if that increase is spread evenly across the keywords, or if it's driven by a few in particular?

I'm looking into the new todo parse failures now.

@keidax
Copy link
Collaborator

keidax commented Jul 7, 2025

The issue with

entries
  .select

is just a logic oversight in scan_whitespace. That should be a quick fix.

The issue with a keyword in a ternary seems more complicated. The Crystal parser has special handling to prevent type declarations inside a ternary, we may need to adopt some of that.

@nobodywasishere
Copy link
Member Author

We can probably ignore the ternary issue for now, fixing this is more important. What do you think the fix is in scan_whitespace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants