feat: Add support for special character control words (emdash, endash, quotes, etc.) #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for RTF special character control words that were previously
parsed as Unknown and silently dropped:
- \emdash → U+2014 (—)
- \endash → U+2013 (–)
- \bullet → U+2022 (•)
- \lquote → U+2018 (')
- \rquote → U+2019 (')
- \ldblquote → U+201C (")
- \rdblquote → U+201D (")
- \tab → U+0009 (tab)
- \line → U+000A (newline)
This fixes data loss when parsing RTF from applications like Scrivener
that use these control words extensively.
Includes 6 new unit tests covering all special characters.
Owner
|
Thanks for this PR, this looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for special character control words that are currently parsed as
Unknownand silently dropped.Characters added:
\emdash) → —\endash) → –\bullet) → •\lquote,\rquote) → ' '\ldblquote,\rdblquote) → " "\tab)\line)Problem
RTF files from applications like Scrivener use these control words extensively. Currently they're silently dropped, causing data loss.
Input RTF:
The transformation in reverse\emdash confident expert
Current output:
The transformation in reverseconfident expert(dash missing)With this PR:
The transformation in reverse—confident expertTesting
Added 6 unit tests for special character parsing.
Breaking changes
None. Previously unknown control words are now recognized and converted to their Unicode equivalents.