Fix #32574: Handle callable objects with custom __signature__ in get_type_hints #32650
+80
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #32574
This PR fixes an issue where
get_type_hints()incorrectly handled callable objects with custom__signature__attributes. Previously, these objects would fail with aTypeErrorbecausetyping.get_type_hints()cannot introspect arbitrary callable instances.Problem
When a callable object defines a custom
__signature__attribute, the existing implementation would pass the callable instance itself totyping.get_type_hints().This broke use cases where wrappers need to preserve type information from wrapped functions by setting
__signature__.Solution
Modified
get_type_hints()indecorator_utils.pyto:__signature__attribute first (highest priority).typing.get_type_hints().Changes
python_modules/dagster/dagster/_core/decorator_utils.py:get_type_hints()to extract annotations directly from__signature__when presentpython_modules/dagster/dagster_tests/definitions_tests/test_sensor_invocation.py:test_sensor_invocation_resources_callable_with_custom_signature()Testing
test_sensor_invocation_resources_callable_with_custom_signaturepassestest_sensor_invocation.pytests pass