Skip to content

Commit 0adc85c

Browse files
fix: user image is null (#3299)
1 parent 42ef591 commit 0adc85c

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

__tests__/updateUserInfo.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {
1010
} from './helpers';
1111
import { User } from '../src/entity';
1212
import { clearFile, UploadPreset } from '../src/common/cloudinary';
13+
import { fallbackImages } from '../src/config';
1314

1415
let con: DataSource;
1516
let state: GraphQLTestingState;
@@ -254,7 +255,7 @@ describe('mutation updateUserInfo', () => {
254255
expect(res.errors).toBeFalsy();
255256

256257
const updatedUser = await repo.findOneBy({ id: loggedUser });
257-
expect(updatedUser?.image).toBeNull();
258+
expect(updatedUser?.image).toBe(fallbackImages.avatar);
258259
expect(clearFile).toHaveBeenCalledWith({
259260
referenceId: loggedUser,
260261
preset: UploadPreset.Avatar,
@@ -318,7 +319,7 @@ describe('mutation updateUserInfo', () => {
318319
expect(res.errors).toBeFalsy();
319320

320321
const updatedUser = await repo.findOneBy({ id: loggedUser });
321-
expect(updatedUser?.image).toBeNull();
322+
expect(updatedUser?.image).toBe(fallbackImages.avatar);
322323
expect(updatedUser?.cover).toBeNull();
323324

324325
expect(clearFile).toHaveBeenCalledTimes(2);

src/schema/users.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ import {
115115
import { markdown } from '../common/markdown';
116116
import { deleteRedisKey, getRedisObject, RedisMagicValues } from '../redis';
117117
import {
118+
fallbackImages,
118119
generateStorageKey,
119120
RESUME_BUCKET_NAME,
120121
StorageKey,
@@ -2542,7 +2543,7 @@ export const resolvers: IResolvers<unknown, BaseContext> = traceResolvers<
25422543
const file = await upload;
25432544
return (await uploadAvatar(user.id, file.createReadStream())).url;
25442545
}
2545-
return data.image || null;
2546+
return data.image || fallbackImages.avatar;
25462547
})(),
25472548
(async () => {
25482549
if (coverUpload && cloudinaryUrl) {

0 commit comments

Comments
 (0)