feat: add support for multiple squad posting and notification dedup #3154

ilasw · 2025-09-22T15:53:52Z

Jira ticket

pulumi · 2025-09-22T15:54:39Z

🍹 The Update (preview) for dailydotdev/api/prod (at 139b1bf) was successful.

Resource Changes

    Name                                                   Type                           Operation
~   vpc-native-update-highlighted-views-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-personalized-digest-deployment              kubernetes:apps/v1:Deployment  update
~   vpc-native-update-views-cron                           kubernetes:batch/v1:CronJob    update
~   vpc-native-hourly-notification-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-user-companies-cron            kubernetes:batch/v1:CronJob    update
~   vpc-native-generate-search-invites-cron                kubernetes:batch/v1:CronJob    update
+   vpc-native-api-db-migration-ea9dd875                   kubernetes:batch/v1:Job        create
~   vpc-native-bg-deployment                               kubernetes:apps/v1:Deployment  update
~   vpc-native-sync-subscription-with-cio-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-daily-digest-cron                           kubernetes:batch/v1:CronJob    update
~   vpc-native-personalized-digest-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-update-source-public-threshold-cron         kubernetes:batch/v1:CronJob    update
~   vpc-native-ws-deployment                               kubernetes:apps/v1:Deployment  update
~   vpc-native-validate-active-users-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-private-deployment                          kubernetes:apps/v1:Deployment  update
~   vpc-native-clean-zombie-users-cron                     kubernetes:batch/v1:CronJob    update
-   vpc-native-api-db-migration-34ee84f3                   kubernetes:batch/v1:Job        delete
~   vpc-native-calculate-top-readers-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-images-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-gifted-plus-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-update-source-tag-view-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tag-recommendations-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-post-analytics-clickhouse-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-update-current-streak-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tags-str-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-temporal-deployment                         kubernetes:apps/v1:Deployment  update
~   vpc-native-generic-referral-reminder-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-stale-user-transactions-cron          kubernetes:batch/v1:CronJob    update
~   vpc-native-check-analytics-report-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-update-trending-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-post-analytics-history-day-clickhouse-cron  kubernetes:batch/v1:CronJob    update
~   vpc-native-deployment                                  kubernetes:apps/v1:Deployment  update
-   vpc-native-api-clickhouse-migration-34ee84f3           kubernetes:batch/v1:Job        delete
+   vpc-native-api-clickhouse-migration-ea9dd875           kubernetes:batch/v1:Job        create

…on handling

…i-1043-multiple-squad-posting

… with validation and tests

…i-1043-multiple-squad-posting

ilasw · 2025-09-25T14:14:03Z

src/common/post.ts

  });
 };

-export const createFreeformPost = async ({


Renamed, now createFreeformPost is a new function that also do some checks before insert

ilasw · 2025-09-25T14:18:14Z

src/common/post.ts

+export const createFreeformPost = async (
+  ctx: AuthContext,
+  args: CreatePostArgs,
+) => {


This is the old createFreeformPost function plus the checks that the endpoint was doing before calling it

ilasw · 2025-09-25T14:19:18Z

src/schema/posts.ts

      }));
    },
    editPost: async (
-      source,


ilasw · 2025-09-25T14:21:56Z

src/schema/sources.ts

 type PostPermissions = SourcePermissions.Post | SourcePermissions.PostRequest;

 export const canPostToSquad = (
-  ctx: Context,


This was not used by the function

…additional properties

Copilot

Pull Request Overview

This pull request adds support for multiple squad posting functionality and implements notification deduplication. The key changes enable users to create posts across multiple sources (squads) with a single operation while preventing duplicate notifications through a deduplication mechanism.

Adds a new createMultipleSourcePosts GraphQL mutation for cross-squad posting
Implements notification deduplication using dedupKey to prevent duplicate notifications
Adds warning reasons for moderation items to flag multiple squad posts and duplicated content

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`src/schema/posts.ts`	Adds new GraphQL mutation and resolver for multiple source posting with validation and permission checks
`src/common/post.ts`	Implements core logic for creating posts across multiple sources with deduplication and warning systems
`src/notifications/`	Adds deduplication support to notifications system using dedupKey parameter
`src/entity/SourcePostModeration.ts`	Adds warning reasons enum and deduplication flags to moderation system
`src/migration/`	Creates database index for deduplication key performance optimization
`__tests__/posts.ts`	Comprehensive test coverage for multiple source posting functionality

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/migration/1758797445760-SourcePostModerationFlagsDedup.ts

src/common/post.ts

Copilot · 2025-09-25T14:24:26Z

src/common/post.ts

+  title: z.string().max(MAX_TITLE_LENGTH).optional(),
+  content: z.string().max(MAX_CONTENT_LENGTH).optional(),
+  image: z.custom<Promise<FileUpload>>(),
+  sourceIds: z.array(z.string()).min(1).max(MAX_MULTIPLE_POST_SOURCE_LIMIT),


The constant MAX_MULTIPLE_POST_SOURCE_LIMIT is defined but never used elsewhere. Consider adding a descriptive comment explaining why this specific limit exists and what happens when it's exceeded.

I half agree with the bot. I'm not sure if we need to define constants that aren't exported and only used one place in zod schemas ? 😅

Co-authored-by: Copilot <[email protected]>

…urces

capJavert

Feels almost there, just please address final comments and I think we still miss tests for notification dedup part.

src/common/post.ts

src/notifications/common.ts

capJavert · 2025-10-01T09:13:39Z

src/notifications/common.ts

+  return [uniqueKey, referenceId, referenceType, dedupKey]
+    .filter(Boolean)
+    .join(':');


still missing post notification tests for dedup logic?

__tests__/posts.ts

…i-1043-multiple-squad-posting

…same dedupKey

…into mi-1043-multiple-squad-posting

capJavert · 2025-10-03T08:58:47Z

src/common/post.ts

+    return WarningReason.MultipleSquadPost;
+  }
+
+  return;


not needed at the end?

capJavert · 2025-10-03T09:00:21Z

src/common/post.ts

+    return WarningReason.DuplicatedInSameSquad;
+  }
+
+  const isDuplicatedAcrossSquads = await hasDuplicatedPostBy(con, {


why do we call hasDuplicatedPostBy twice, once with sourceId once without? Would it not do the same thing if sourceId is not passed thus doing the query twice?

rebelchris

Non blocking, but good to check that one by Ante.
Logic wise will approve from my side.

rebelchris · 2025-10-03T09:07:35Z

src/common/post.ts

+    return;
+  }
+
+  const isDuplicatedInSameSquad = await hasDuplicatedPostBy(con, {


I still think this could be 1 query 😅

rebelchris · 2025-10-03T09:10:05Z

src/schema/posts.ts

+      return await ctx.con.transaction(async (entityManager) => {
+        const output: Array<MultipleSourcesPostResult> = [];
+        for (const sourceId of sourceIds) {


@capJavert the for loop works well with async right?
Or should be for await (?

works ok yes

rebelchris · 2025-10-03T09:11:40Z

@claude please review this, but focus only on breaking changes.

claude · 2025-10-03T09:11:53Z

Claude finished @rebelchris's task —— View job

Breaking Changes Review

Reviewing PR for breaking changes as requested by @rebelchris.

Tasks:

Analyze GraphQL schema changes for API breaking changes
Review database migrations for schema breaking changes
Check core logic changes for behavioral breaking changes
Review entity changes for data model breaking changes
Provide focused breaking changes summary

✅ NO BREAKING CHANGES IDENTIFIED

After thorough analysis of this PR, I found no breaking changes:

GraphQL API Changes:

✅ Non-breaking: New mutation createPostInMultipleSources added (additive)
✅ Non-breaking: New types MultiplePostItem and MultiplePostItemType enum added (additive)
✅ Non-breaking: No existing mutations/queries modified or removed

Database Schema Changes:

✅ Non-breaking: Only new index IDX_source_post_moderation_flags_dedupKey added (performance improvement)
✅ Non-breaking: No table columns added/removed/modified
✅ Non-breaking: No foreign key constraints changed

Entity & Data Model Changes:

✅ Non-breaking: New enum WarningReason and flags added to SourcePostModerationFlags (optional fields)
✅ Non-breaking: No existing fields removed or type changes

Core Logic Changes:

✅ Non-breaking: New functions createFreeformPost and insertFreeformPost refactor existing logic without changing interfaces
✅ Non-breaking: Notification deduplication is purely additive functionality
✅ Non-breaking: No existing function signatures changed

Summary: This PR is safe to merge from a breaking changes perspective. All changes are additive features that enhance functionality without affecting existing APIs or data structures.

…into mi-1043-multiple-squad-posting

feat: add dedupKey support for notifications

f7e4d91

ilasw added 10 commits September 23, 2025 10:29

Merge branch 'main' into mi-1043-multiple-squad-posting

234b6d0

feat: add support for warning reasons in SourcePostModeration flags

11a5d71

feat: add support for multiple source posts creation with deduplicati…

5bd9cce

…on handling

refactor: better post deduplication checks

512dadb

refactor: added isMultiplePosting check && removed unused context params

c5f0e74

refactor: added transaction scope for post creation

646ef2c

Merge branch 'main' of https://github.com/dailydotdev/daily-api into m…

83e08f1

…i-1043-multiple-squad-posting

feat: added dedupKey index and improved multiple source post creation…

6b237f2

… with validation and tests

Merge branch 'main' of https://github.com/dailydotdev/daily-api into m…

4d80092

…i-1043-multiple-squad-posting

test: clean up test data after each posts test run

aa21828

ilasw commented Sep 25, 2025

View reviewed changes

src/schema/posts.ts

}));

},

editPost: async (

source,

Copy link

Contributor Author

ilasw Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was unused

ilasw commented Sep 25, 2025

View reviewed changes

ilasw added 2 commits September 25, 2025 16:22

test: updated moderation item tests to check falsy warningReason and …

c466221

…additional properties

refactor: revert con to ctx reducing changes

65fcbe8

ilasw requested a review from Copilot September 25, 2025 14:23

ilasw marked this pull request as ready for review September 25, 2025 14:23

ilasw requested review from a team and capJavert as code owners September 25, 2025 14:23

ilasw requested review from AmarTrebinjac, nensidosari, omBratteng, rebelchris and sshanzel September 25, 2025 14:23

Copilot AI reviewed Sep 25, 2025

View reviewed changes

ilasw and others added 2 commits September 25, 2025 16:26

fix: wrong migration

a641e60

Co-authored-by: Copilot <[email protected]>

fix: missing optional image in schema

ddb96ef

Co-authored-by: Copilot <[email protected]>

Merge branch 'main' into mi-1043-multiple-squad-posting

9d3a222

ilasw requested review from AmarTrebinjac and rebelchris September 29, 2025 18:22

ilasw added 3 commits September 30, 2025 12:54

fix: uniqueKey generation for notifications and updated tests

9713a0a

refactor: renamed isMultiplePosting to isMultiPost

4175c0b

refactor: renamed createMultipleSourcesPost to createPostInMultipleSo…

08dc152

…urces

ilasw requested a review from capJavert September 30, 2025 14:05

ilasw added 2 commits September 30, 2025 17:27

Merge branch 'main' into mi-1043-multiple-squad-posting

26ab10c

feat: add multiple squads posting for polls (#3175)

c01e373

capJavert reviewed Oct 1, 2025

View reviewed changes

__tests__/posts.ts Show resolved Hide resolved

ilasw added 8 commits October 2, 2025 12:27

Merge branch 'main' of https://github.com/dailydotdev/daily-api into m…

8ff6199

…i-1043-multiple-squad-posting

feat: added external link support for multiple squad posts

b79064c

refactor: simplified entityManager usage in post creation functions

b68902f

refactor: replaced getOne with getExists

f894315

test: added test to ensure no duplicate notifications for posts with …

ae3f7b0

…same dedupKey

Merge branch 'main' into mi-1043-multiple-squad-posting

3f79f1d

fix: removed unnecessary checks for post

2e1e971

Merge remote-tracking branch 'origin/mi-1043-multiple-squad-posting' …

dc74b90

…into mi-1043-multiple-squad-posting

ilasw requested a review from capJavert October 3, 2025 07:45

Merge branch 'main' into mi-1043-multiple-squad-posting

4dadd0d

capJavert approved these changes Oct 3, 2025

View reviewed changes

rebelchris approved these changes Oct 3, 2025

View reviewed changes

ilasw added 3 commits October 3, 2025 12:07

refactor: updated duplication checks

9bfbd16

Merge remote-tracking branch 'origin/mi-1043-multiple-squad-posting' …

f8f4c9a

…into mi-1043-multiple-squad-posting

Merge branch 'main' into mi-1043-multiple-squad-posting

139b1bf

ilasw merged commit 1839e7f into main Oct 3, 2025
9 checks passed

ilasw deleted the mi-1043-multiple-squad-posting branch October 3, 2025 10:35

feat: add support for multiple squad posting and notification dedup #3154

feat: add support for multiple squad posting and notification dedup #3154

Uh oh!

Conversation

ilasw commented Sep 22, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jira ticket

Uh oh!

pulumi bot commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Resource Changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

capJavert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rebelchris left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rebelchris commented Oct 3, 2025

Uh oh!

claude bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking Changes Review

✅ NO BREAKING CHANGES IDENTIFIED

GraphQL API Changes:

Database Schema Changes:

Entity & Data Model Changes:

Core Logic Changes:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ilasw commented Sep 22, 2025 •

edited by github-actions bot

Loading

pulumi bot commented Sep 22, 2025 •

edited

Loading

claude bot commented Oct 3, 2025 •

edited

Loading