Use emacs diff colors #34
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve syntax highlighting by sending the emacs diff colors to delta.
This way, the colors should better match the background.
I have also added
magit-delta-max-sizeto avoid running delta on large files since it's easier to do now (I can move it to later PR if you prefer).This should also fix #28.
A few notes:
magit-delta-modeis now a global mode.Since we are using diff faces, we need to have the correct faces already loaded when enabling
magit-delta-mode. For example, if we enablemagit-delta-modebefore setting up a theme, we would use the wrong colors.Using
(add-hook 'magit-mode-hook (lambda () (magit-delta-mode +1)))works since by the time we turn on magit mode, the faces should be correct.Before:
After: