DAOS-18195 common: improve chunk reinit + verbose assert #17139
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sherin T George <[email protected]>
|
Errors are Unable to load ticket data |
janekmi
commented
Nov 17, 2025
src/common/dav/heap.c
Outdated
Comment on lines
819
to
820
| D_ASSERTF(0, "Encounted invalid chunk (%d) of type %d val = 0x%lx", i, | ||
| hdr->type, *(uint64_t *)hdr); |
Contributor
Author
There was a problem hiding this comment.
- Nitpick. Spelling.
- Minor. Type is unsigned.
Suggested change
| D_ASSERTF(0, "Encounted invalid chunk (%d) of type %d val = 0x%lx", i, | |
| hdr->type, *(uint64_t *)hdr); | |
| D_ASSERTF(0, "Encountered invalid chunk (%d) of type %u val = 0x%lx", i, | |
| hdr->type, *(uint64_t *)hdr); |
Collaborator
There was a problem hiding this comment.
Thanks. Will correct it.
Addressed review comments. Signed-off-by: Sherin T George <[email protected]>
janekmi
commented
Nov 20, 2025
| struct chunk_header *hdr = heap_get_chunk_hdr(m->heap, m); | ||
|
|
||
| if (hdr->type == CHUNK_TYPE_USED) | ||
| if ((hdr->type == CHUNK_TYPE_USED) || (hdr->type == CHUNK_TYPE_FREE)) |
Contributor
Author
There was a problem hiding this comment.
I just realized this if basically means: all allowed chunk types for this particular callback. 🤣 Since this function should not be called for any other type except for CHUNK_TYPE_USED and CHUNK_TYPE_FREE, should it?
Suggested change
| if ((hdr->type == CHUNK_TYPE_USED) || (hdr->type == CHUNK_TYPE_FREE)) | |
| D_ASSERTF(hdr->type == CHUNK_TYPE_USED || hdr->type == CHUNK_TYPE_FREE); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps for the author:
After all prior steps are complete: