Workflow versioning #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshVanL
requested changes
Nov 10, 2025
acroca
force-pushed
the
workflow-versioning
branch
2 times, most recently
from
0297ee6 to
a088915
Compare
acroca
force-pushed
the
workflow-versioning
branch
5 times, most recently
from
437d90e to
5bac21c
Compare
Signed-off-by: Albert Callarisa <[email protected]>
Signed-off-by: Albert Callarisa <[email protected]>
…nation Signed-off-by: Albert Callarisa <[email protected]>
Signed-off-by: Albert Callarisa <[email protected]>
acroca
force-pushed
the
workflow-versioning
branch
from
3efe98a to
330ef46
Compare
JoshVanL
requested changes
Nov 25, 2025
Signed-off-by: Albert Callarisa <[email protected]>
Signed-off-by: Albert Callarisa <[email protected]>
JoshVanL
requested changes
Nov 25, 2025
protos/orchestrator_service.proto
Outdated
Comment on lines
378
to
379
| optional Patches patches = 7; | ||
| bool patchMismatch = 8; |
There was a problem hiding this comment.
Please wrap related fields into new messages to have better logical grouping and cleaner API extentions.
Signed-off-by: Albert Callarisa <[email protected]>
Signed-off-by: Albert Callarisa <[email protected]>
Member
Author
|
@JoshVanL I reorganised things a bit, please have a look. I ended up reusing the |
Signed-off-by: Albert Callarisa <[email protected]>
acroca
commented
Nov 27, 2025
protos/orchestrator_service.proto
Outdated
| ORCHESTRATION_STATUS_TERMINATED = 5; | ||
| ORCHESTRATION_STATUS_PENDING = 6; | ||
| ORCHESTRATION_STATUS_SUSPENDED = 7; | ||
| ORCHESTRATION_STATUS_PENDING_PATCH_MISMATCH = 8; |
Member
Author
There was a problem hiding this comment.
Q: Based on this comment, do we really want to have different PENDING_ status every time we add a new reason for a workflow to enter a temporary pending status?
There was a problem hiding this comment.
Makes sense, let's have a single PENDING OrchestrationStatus, with typed enum reasons.
JoshVanL
requested changes
Nov 27, 2025
protos/orchestrator_service.proto
Outdated
| optional string targetAppID = 2; | ||
| } | ||
|
|
||
| message OrchestrationVersioningInformation { |
There was a problem hiding this comment.
Information is superfluous. Should use the noun "Version".
Suggested change
| message OrchestrationVersioningInformation { | |
| message OrchestrationVersion { |
protos/orchestrator_service.proto
Outdated
| ORCHESTRATION_STATUS_TERMINATED = 5; | ||
| ORCHESTRATION_STATUS_PENDING = 6; | ||
| ORCHESTRATION_STATUS_SUSPENDED = 7; | ||
| ORCHESTRATION_STATUS_PENDING_PATCH_MISMATCH = 8; |
There was a problem hiding this comment.
Makes sense, let's have a single PENDING OrchestrationStatus, with typed enum reasons.
protos/orchestrator_service.proto
Outdated
|
|
||
| message OrchestratorStartedEvent { | ||
| // No payload data | ||
| optional OrchestrationVersioningInformation versioningInformation = 1; |
There was a problem hiding this comment.
Suggested change
| optional OrchestrationVersioningInformation versioningInformation = 1; | |
| optional OrchestrationVersion version = 1; |
protos/orchestrator_service.proto
Outdated
| EntityLockRequestedEvent entityLockRequested = 27; | ||
| EntityLockGrantedEvent entityLockGranted = 28; | ||
| EntityUnlockSentEvent entityUnlockSent = 29; | ||
| ExecutionPendingVersionEvent executionPendingVersion = 31; |
There was a problem hiding this comment.
Suggested change
| ExecutionPendingVersionEvent executionPendingVersion = 31; | |
| ExecutionPending executionPending = 31; |
protos/orchestrator_service.proto
Outdated
| google.protobuf.StringValue input = 1; | ||
| } | ||
|
|
||
| message ExecutionPendingVersionEvent { |
There was a problem hiding this comment.
Suggested change
| message ExecutionPendingVersionEvent { | |
| message ExecutionPending { | |
| PendingReason reason = 1; | |
| // Ideally we would have more stringy information here which would tell the user what went wrong, which will be surfaced in `dapr workfow history` etc. | |
| } | |
Signed-off-by: Albert Callarisa <[email protected]>
JoshVanL
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds changes to introduce workflow versioning as described in dapr/proposals#94