-
Notifications
You must be signed in to change notification settings - Fork 131
Refactor 404 error page to use div instead of p for search form #4038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor 404 error page to use div instead of p for search form #4038
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
30a8960 to
bf2981b
Compare
|
Thanks for you contribution. Can you rebase and maybe take a look at the failing tests? |
The search form on the 404 error page was previously wrapped in a `<p>` tag, which is semantically incorrect as `<p>` tags cannot contain block-level elements like `<form>`. This commit refactors the page to use a `<div>` tag instead, which is a more appropriate container for the search form. This change improves the semantic structure of the page and avoids potential rendering issues.
bf2981b to
e3f847d
Compare
szakarias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased on to main
|
Thanks to approve it!! |
|
Was this landed? |
|
No, I made a copy of it here #4064 . @AndrewDongminYoo is it okay with you if we land the copy? Otherwise maybe you could restore the branch and this PR? |
|
@szakarias Yes, totally fine! Thanks for taking care of it :) |
The 404 error page’s search form was wrapped in a <p> tag, but <p> cannot contain block-level elements like <form>. This change refactors the markup to use a <div> instead, which:
Files changed:
doc/api/__404error.html(replace <p>…</p> around the form with <div>…</div>)No behavior changes beyond markup.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.