-
Notifications
You must be signed in to change notification settings - Fork 391
fix(cupertino_http): Disable local close code tests on macOS #1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Disabling the tests due to dart-lang#1814
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with
API leaks
|
| Package | Leaked API symbol | Leaking sources |
|---|---|---|
| cupertino_http | ncb.NSURLCache | cupertino_api.dart::URLCache native_cupertino_bindings.dart::NSURLCache::getSharedURLCache native_cupertino_bindings.dart::NSURLCache::setSharedURLCache::value native_cupertino_bindings.dart::NSURLCache::initWithMemoryCapacity native_cupertino_bindings.dart::NSURLCache::initWithMemoryCapacity$1 native_cupertino_bindings.dart::NSURLCache::init native_cupertino_bindings.dart::NSURLCache::new$ native_cupertino_bindings.dart::NSURLCache::allocWithZone native_cupertino_bindings.dart::NSURLCache::alloc native_cupertino_bindings.dart::NSURLCache::self$1 native_cupertino_bindings.dart::NSURLCache::retain native_cupertino_bindings.dart::NSURLCache::autorelease native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCache native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCache |
| cupertino_http | NSURLRequest | native_cupertino_bindings.dart::NSURLCache::cachedResponseForRequest::request native_cupertino_bindings.dart::NSURLRequest::requestWithURL native_cupertino_bindings.dart::NSURLRequest::requestWithURL$1 native_cupertino_bindings.dart::NSURLRequest::initWithURL native_cupertino_bindings.dart::NSURLRequest::initWithURL$1 native_cupertino_bindings.dart::NSURLRequest::init native_cupertino_bindings.dart::NSURLRequest::new$ native_cupertino_bindings.dart::NSURLRequest::allocWithZone native_cupertino_bindings.dart::NSURLRequest::alloc native_cupertino_bindings.dart::NSURLRequest::self$1 native_cupertino_bindings.dart::NSURLRequest::retain native_cupertino_bindings.dart::NSURLRequest::autorelease native_cupertino_bindings.dart::NSURLRequest::initWithCoder native_cupertino_bindings.dart::NSURLCache::storeCachedResponse::forRequest native_cupertino_bindings.dart::NSURLCache::removeCachedResponseForRequest::request |
| cupertino_http | NSURLRequestAttribution | native_cupertino_bindings.dart::NSURLRequest::attribution native_cupertino_bindings.dart::NSURLRequestAttribution::NSURLRequestAttributionDeveloper native_cupertino_bindings.dart::NSURLRequestAttribution::NSURLRequestAttributionUser native_cupertino_bindings.dart::NSURLRequestAttribution::values native_cupertino_bindings.dart::NSURLRequestAttribution::fromValue |
| cupertino_http | NSCachedURLResponse | native_cupertino_bindings.dart::NSURLCache::cachedResponseForRequest native_cupertino_bindings.dart::NSURLCache::storeCachedResponse::cachedResponse |
| cupertino_http | ncb.NSURLSessionDelegate | cupertino_api.dart::URLSession::delegate |
| cupertino_http | ncb.NSURLSessionConfiguration | cupertino_api.dart::URLSessionConfiguration native_cupertino_bindings.dart::NSURLSessionConfiguration::getDefaultSessionConfiguration native_cupertino_bindings.dart::NSURLSessionConfiguration::getEphemeralSessionConfiguration native_cupertino_bindings.dart::NSURLSessionConfiguration::backgroundSessionConfigurationWithIdentifier native_cupertino_bindings.dart::NSURLSessionConfiguration::init native_cupertino_bindings.dart::NSURLSessionConfiguration::new$ native_cupertino_bindings.dart::NSURLSessionConfiguration::allocWithZone native_cupertino_bindings.dart::NSURLSessionConfiguration::alloc native_cupertino_bindings.dart::NSURLSessionConfiguration::self$1 native_cupertino_bindings.dart::NSURLSessionConfiguration::retain native_cupertino_bindings.dart::NSURLSessionConfiguration::autorelease |
| cupertino_http | SSLProtocol | native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocol native_cupertino_bindings.dart::SSLProtocol::kSSLProtocolUnknown native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol1 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol11 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol12 native_cupertino_bindings.dart::SSLProtocol::kDTLSProtocol1 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol13 native_cupertino_bindings.dart::SSLProtocol::kDTLSProtocol12 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocolMaxSupported native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol2 native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol3 native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol3Only native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol1Only native_cupertino_bindings.dart::SSLProtocol::kSSLProtocolAll native_cupertino_bindings.dart::SSLProtocol::values native_cupertino_bindings.dart::SSLProtocol::fromValue native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocol native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocol native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocol |
| cupertino_http | tls_protocol_version_t | native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocolVersion native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv10 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv11 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv12 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv13 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_DTLSv10 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_DTLSv12 native_cupertino_bindings.dart::tls_protocol_version_t::values native_cupertino_bindings.dart::tls_protocol_version_t::fromValue native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocolVersion native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocolVersion native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocolVersion |
| cupertino_http | NSHTTPCookieStorage | native_cupertino_bindings.dart::NSURLSessionConfiguration::HTTPCookieStorage native_cupertino_bindings.dart::NSURLSessionConfiguration::HTTPCookieStorage |
| cupertino_http | NSURLCredentialStorage | native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCredentialStorage native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCredentialStorage |
This check can be disabled by tagging the PR with skip-leaking-check.
Breaking changes ⚠️
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| cupertino_http | Breaking | 2.3.0 | 2.4.0-wip | 3.0.0 Got "2.4.0-wip" expected >= "3.0.0" (breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check.
Coverage ⚠️
| File | Coverage |
|---|---|
| pkgs/cupertino_http/example/integration_test/url_session_task_test.dart | 💔 Not covered |
| pkgs/cupertino_http/example/integration_test/web_socket_conformance_test.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
Changelog Entry ❗
| Package | Changed Files |
|---|---|
| package:cupertino_http | pkgs/cupertino_http/example/pubspec.yaml |
Changes to files need to be accounted for in their respective changelogs.
This check can be disabled by tagging the PR with skip-changelog-check.
Disabling the tests due to #1814
Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.