Skip to content

Conversation

@parlough
Copy link
Member

@parlough parlough commented Jul 2, 2025

Adding Dart to the image as we want to use Dart in the site build. Using beta as sometimes we depend on upcoming features, particularly when preparing for a new stable release.

@parlough parlough requested a review from athomas July 2, 2025 06:55
@parlough
Copy link
Member Author

parlough commented Jul 2, 2025

@athomas I'm not really familiar with Cloud Build, do you see any problems with making this change or is there a better way to do this (using a mirrored version of the official Dart Docker image?). Thanks for any insight you have :)

FROM marketplace.gcr.io/google/debian12

# Install prerequisite dependencies.
RUN apt-get update && apt-get install -y curl gpg apt-transport-https
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to not just change the first line to the Dart official image?
FROM dart:beta

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if it Cloud Build required using a gcr.io hosted image as the base image, so I went with this.

Looking more now though, https://cloud.google.com/build/docs/interacting-with-dockerhub-images does explicitly mention docker hub images are supported, so I'll try it out! Has the added benefit of supporting arm if needed.

@athomas
Copy link
Member

athomas commented Jul 2, 2025

@athomas I'm not really familiar with Cloud Build, do you see any problems with making this change or is there a better way to do this (using a mirrored version of the official Dart Docker image?). Thanks for any insight you have :)

I wouldn't exactly call myself a Cloud Build expert, but thanks for your trust :)

I'd say it would be nice to use the Dart official image (also to dogfood our own products). But what you have should work as well.

@parlough parlough merged commit 98457e2 into main Jul 2, 2025
9 checks passed
@parlough parlough deleted the feat/include-dart-in-build-image branch July 2, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants