Remove some unnecessary functions

Author: TCeason

src/common/column/src/fixedsizebinary/builder.rs

@@ -78,44 +78,12 @@ impl FixedSizeBinaryColumnBuilder {
         self.data.len()
     }
 
-    pub fn push_default(&mut self) {
-        self.data.extend_from_slice(&vec![0; self.value_length]);
-    }
-
-    pub fn put_char(&mut self, item: char) {
-        self.data
-            .extend_from_slice(item.encode_utf8(&mut [0; 4]).as_bytes());
-    }
-
-    #[inline]
-    pub fn put_str(&mut self, item: &str) {
-        debug_assert!(self.value_length == item.len());
-        self.data.extend_from_slice(item.as_bytes());
-    }
-
     #[inline]
     pub fn put_slice(&mut self, item: &[u8]) {
         debug_assert!(self.value_length == item.len());
         self.data.extend_from_slice(item);
     }
 
-    #[inline]
-    pub fn commit_row(&mut self) {
-        self.data.reserve(self.data.capacity());
-    }
-
-    pub fn put_char_iter(&mut self, iter: impl Iterator<Item = char>) {
-        for c in iter {
-            let mut buf = [0; 4];
-            let result = c.encode_utf8(&mut buf);
-            self.data.extend_from_slice(result.as_bytes());
-        }
-    }
-
-    pub fn put(&mut self, item: &[u8]) {
-        self.data.extend_from_slice(item);
-    }
-
     pub fn append_column(&mut self, other: &FixedSizeBinaryColumn) {
         debug_assert!(other.value_length == self.value_length);
         self.data.extend_from_slice(&other.data);
@@ -175,7 +143,6 @@ impl FixedSizeBinaryColumnBuilder {
     {
         for item in iterator {
             self.put_slice(item.as_ref());
-            self.commit_row();
         }
     }
 }

src/query/expression/src/aggregate/payload_flush.rs

@@ -339,7 +339,6 @@ impl Payload {
                     as usize as *const u8;
                 let scalar = std::slice::from_raw_parts(data_address, str_len);
                 fixed_size_binary_builder.put_slice(scalar);
-                fixed_size_binary_builder.commit_row();
             }
         }
         fixed_size_binary_builder.build()

src/query/expression/src/kernels/take_chunks.rs

@@ -818,7 +818,6 @@ impl Column {
                 builder.put_slice(
                     col[row_ptr.chunk_index as usize].index_unchecked(row_ptr.row_index as usize),
                 );
-                builder.commit_row();
             }
         }
         builder.build()

src/query/expression/src/types/interval.rs

@@ -135,16 +135,14 @@ impl ValueType for IntervalType {
 
     fn push_item(builder: &mut Self::ColumnBuilder, item: Self::ScalarRef<'_>) {
         builder.put_slice(item);
-        builder.commit_row();
     }
 
     fn push_item_repeat(builder: &mut Self::ColumnBuilder, item: Self::ScalarRef<'_>, n: usize) {
         builder.push_repeat(item, n);
     }
 
     fn push_default(builder: &mut Self::ColumnBuilder) {
-        builder.push_default();
-        builder.commit_row();
+        builder.put_slice(&vec![0; builder.value_length]);
     }
 
     fn append_column(builder: &mut Self::ColumnBuilder, other_builder: &Self::Column) {

src/query/expression/src/values.rs

@@ -2006,7 +2006,7 @@ impl ColumnBuilder {
                 builder.commit_row();
             }
             ColumnBuilder::Geometry(builder) => builder.commit_row(),
-            ColumnBuilder::Interval(builder) => builder.push_default(),
+            ColumnBuilder::Interval(builder) => builder.put_slice(&vec![0; builder.value_length]),
             ColumnBuilder::Geography(builder) => builder.commit_row(),
         }
     }
@@ -2147,7 +2147,6 @@ impl ColumnBuilder {
                 for row in 0..rows {
                     let reader = &reader[step * row..];
                     builder.put_slice(reader);
-                    builder.commit_row();
                 }
             }
             ColumnBuilder::Binary(builder)

src/query/formats/src/field_decoder/fast_values.rs

@@ -522,7 +522,6 @@ impl FastFieldDecoderValues {
                 .to_le_bytes()
                 .as_bytes(),
         );
-        column.commit_row();
         Ok(())
     }
 

src/query/formats/src/field_decoder/nested.rs

@@ -277,7 +277,6 @@ impl NestedValues {
                 .to_le_bytes()
                 .as_bytes(),
         );
-        column.commit_row();
         Ok(())
     }
 

src/query/formats/src/field_decoder/separated_text.rs

@@ -278,7 +278,6 @@ impl SeparatedTextDecoder {
                 .to_le_bytes()
                 .as_bytes(),
         );
-        column.commit_row();
         Ok(())
     }
 

src/query/functions/src/scalars/interval.rs

@@ -60,7 +60,6 @@ fn register_string_to_interval(registry: &mut FunctionRegistry) {
                     ctx.set_error(0, format!("cannot parse to type `INTERVAL`. {}", e));
                 }
             }
-            output.commit_row();
         })(val, ctx)
     }
 }