Skip to content

fix(storage): fix refresh virtual column using async api #16656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
b41sh merged 4 commits into from
Oct 23, 2024
Merged

fix(storage): fix refresh virtual column using async api #16656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b83bef
fix(storage): fix refresh virtual column using async api
b41sh Oct 22, 2024
43bc9b5
fix typos
b41sh Oct 22, 2024
1480c5a
fix
b41sh Oct 22, 2024
0788ff3
Merge branch 'main' into fix-virtual-column-write
sundy-li Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 22 additions & 0 deletions src/common/metrics/src/metrics/storage.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,15 @@ static AGG_INDEX_WRITE_BYTES: LazyLock<Counter> =
static AGG_INDEX_WRITE_MILLISECONDS: LazyLock<Histogram> =
LazyLock::new(|| register_histogram_in_milliseconds("fuse_aggregate_index_write_milliseconds"));

// Virtual column metrics.
static BLOCK_VIRTUAL_COLUMN_WRITE_NUMS: LazyLock<Counter> =
LazyLock::new(|| register_counter("fuse_block_virtual_column_write_nums"));
static BLOCK_VIRTUAL_COLUMN_WRITE_BYTES: LazyLock<Counter> =
LazyLock::new(|| register_counter("fuse_block_virtual_column_write_bytes"));
static BLOCK_VIRTUAL_COLUMN_WRITE_MILLISECONDS: LazyLock<Histogram> = LazyLock::new(|| {
register_histogram_in_milliseconds("fuse_block_virtual_column_write_milliseconds")
});

/// Common metrics.
pub fn metrics_inc_omit_filter_rowgroups(c: u64) {
OMIT_FILTER_ROWGROUPS.inc_by(c);
Expand Down Expand Up @@ -790,3 +799,16 @@ pub fn metrics_inc_agg_index_write_bytes(c: u64) {
pub fn metrics_inc_agg_index_write_milliseconds(c: u64) {
AGG_INDEX_WRITE_MILLISECONDS.observe(c as f64);
}

/// Virtual column metrics.
pub fn metrics_inc_block_virtual_column_write_nums(c: u64) {
BLOCK_VIRTUAL_COLUMN_WRITE_NUMS.inc_by(c);
}

pub fn metrics_inc_block_virtual_column_write_bytes(c: u64) {
BLOCK_VIRTUAL_COLUMN_WRITE_BYTES.inc_by(c);
}

pub fn metrics_inc_block_virtual_column_write_milliseconds(c: u64) {
BLOCK_VIRTUAL_COLUMN_WRITE_MILLISECONDS.observe(c as f64);
}
5 changes: 5 additions & 0 deletions src/query/ee/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ databend-common-meta-api = { workspace = true }
databend-common-meta-app = { workspace = true }
databend-common-meta-store = { workspace = true }
databend-common-meta-types = { workspace = true }
databend-common-metrics = { workspace = true }
databend-common-pipeline-core = { workspace = true }
databend-common-pipeline-sinks = { workspace = true }
databend-common-pipeline-sources = { workspace = true }
databend-common-pipeline-transforms = { workspace = true }
databend-common-sql = { workspace = true }
databend-common-storage = { workspace = true }
databend-common-storages-fuse = { workspace = true }
Expand Down
Loading
Loading