Skip to content

Conversation

@dantengsky
Copy link
Member

@dantengsky dantengsky commented Dec 16, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

use read_exact in decompress_lz4

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - use existing tests

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@what-the-diff
Copy link

what-the-diff bot commented Dec 16, 2024

PR Summary

  • Included a New File Import
    An import for a particular component of the code library named std::io::Read has been added. This provides additional capabilities for input/output operations in the program.

  • Optimization of LZ4 Frame Decoder Reading Method
    The method of reading information from the LZ4 frame decoder has been altered. Now it's using read_exact instead of read. This guarantees the full utilization of the output buffer, improving the efficiency and precision of the reading process.

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 16, 2024
@dantengsky dantengsky marked this pull request as ready for review December 16, 2024 12:15
@dantengsky dantengsky merged commit 663a1fa into databendlabs:release/v1.2.636-rc8 Dec 16, 2024
73 checks passed
dantengsky added a commit to dantengsky/fuse-query that referenced this pull request Dec 16, 2024
* chore: use read_exact in decompress_lz4

* tweak cargo audit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-chore this PR only has small changes that no need to record, like coding styles.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant