-
Notifications
You must be signed in to change notification settings - Fork 841
feat(query): refactor vacuum temp files #17089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Dec 20, 2024
src/query/ee/src/storages/fuse/operations/vacuum_temporary_files.rs
Outdated
Show resolved
Hide resolved
forsaken628
reviewed
Dec 22, 2024
forsaken628
approved these changes
Dec 22, 2024
2adcc03 to
2da4e77
Compare
everpcpc
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
feat(query): refactor vacuum temp files
VacuumTempOptions::QueryHookonly vacuum temp files after the query finishVacuumTempOptions::VacuumCommandis called via commandVACUUM TEMPORARY FILESIt will list the spill directory
Tests
Type of change
This change is