-
Notifications
You must be signed in to change notification settings - Fork 841
feat(query): Add external_block_rows metrics
#17116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundy-li
reviewed
Dec 25, 2024
src/query/service/src/pipelines/processors/transforms/transform_udf_server.rs
Outdated
Show resolved
Hide resolved
sundy-li
approved these changes
Dec 26, 2024
flaneur2020
reviewed
Dec 26, 2024
flaneur2020
approved these changes
Dec 26, 2024
Member
flaneur2020
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Contributor
Docker Image for PR
|
Contributor
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
external_block_rowsto record the number of rows per block when calling the udf servers.external_request_durationandexternal_connect_durationto record data in milliseconds, and fix the metric data loss caused by the wrong record unit.endpointsin theinit_endpointsfunction.semaphorein theinit_semaphorefunction to make max threads permit in query level instead of transform level.Tests
Type of change
This change is