Skip to content

Conversation

@b41sh
Copy link
Member

@b41sh b41sh commented Dec 25, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. Add a new metrics external_block_rows to record the number of rows per block when calling the udf servers.
  2. Fix the metrics external_request_duration and external_connect_duration to record data in milliseconds, and fix the metric data loss caused by the wrong record unit.
  3. Create endpoints in the init_endpoints function.
  4. Create semaphore in the init_semaphore function to make max threads permit in query level instead of transform level.
  • fixes: #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Dec 25, 2024
Copy link
Member

@flaneur2020 flaneur2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sundy-li sundy-li added the ci-benchmark Benchmark: run all test label Dec 26, 2024
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17116-70916b0-1735189702

note: this image tag is only available for internal use,
please check the internal doc for more details.

@sundy-li
Copy link
Member

image

Perf test is to show performance with the latest release.

It is not related to this pr; it is also seen in the latest changes.

@sundy-li sundy-li added this pull request to the merge queue Dec 26, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Dec 26, 2024
@BohuTANG BohuTANG merged commit ff78344 into databendlabs:main Dec 26, 2024
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-benchmark Benchmark: run all test pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants