Skip to content

fix: analyze table contain keyword bug #17131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BohuTANG merged 1 commit into from
Dec 27, 2024
Merged

fix: analyze table contain keyword bug #17131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/query/service/src/interpreters/interpreter_table_analyze.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,16 @@ impl Interpreter for AnalyzeTableInterpreter {
)
};

let quote = self
.ctx
.get_settings()
.get_sql_dialect()?
.default_ident_quote();
let index_cols: Vec<(u32, String)> = schema
.fields()
.iter()
.filter(|f| RangeIndex::supported_type(&f.data_type().into()))
.map(|f| (f.column_id(), f.name.clone()))
.map(|f| (f.column_id(), format!("{quote}{}{quote}", f.name)))
.collect();

// 0.01625 --> 12 buckets --> 4K size per column
Expand Down
17 changes: 17 additions & 0 deletions tests/sqllogictests/suites/base/09_fuse_engine/09_0020_analyze.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,23 @@ CREATE DATABASE db_09_0020
statement ok
USE db_09_0020

statement ok
create or replace table t_17129(`offset` varchar);

statement ok
insert into t_17129 values('ttt');

statement ok
analyze table t_17129;

query TI
select column_name, distinct_count from fuse_statistic('db_09_0020','t_17129');
----
offset 1

statement ok
drop table t_17129;

statement ok
create table t(a uint64)

Expand Down
Loading