feat(config): warn unknown field instead of panic on start up #17504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
currently databend-query will fail loudly with any unknown field in the config file.
however, this behaviour is not very good in the sense of forward compatibiltity. sometimes we may add new config fields, but when we rollback databend-query into earlier version, it will fail for unknown field in the config file.
we can simply allow these unknown fields by simply removing the
#[serde(deny_unknown_field)]attribute. however, it also has a risk that users might have typo in there config file. it's still better to have some warning about this.this pr introduced
sered_ignoredwhile parsing the toml config file, and print a warning log for any unknown field is found.Tests
Type of change
This change is