-
Notifications
You must be signed in to change notification settings - Fork 841
refactor(executor): control queries executor via configuration #18283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zhang2014
merged 13 commits into
databendlabs:main
from
dqhl76:queries-executor-refactor1
Jul 4, 2025
Merged
refactor(executor): control queries executor via configuration #18283
zhang2014
merged 13 commits into
databendlabs:main
from
dqhl76:queries-executor-refactor1
Jul 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Contributor
Docker Image for PR
|
Collaborator
Author
Behaviour:Enable in configuration: set use_legacy_query_executor = 1;Allow revert by unset use_legacy_query_executor;Allow use set use_legacy_query_executor = 0;
error: APIError: QueryFailed: [2004]This setting is not allowed set to 0, please use unsetNot enable in configuration(default): |
BohuTANG
reviewed
Jul 3, 2025
zhang2014
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci-benchmark
Benchmark: run all test
pr-refactor
this PR changes the code base without new features or bugfix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
enable_queries_executor[query.enable_queries_executor]to allow enable this featureset disable_queries_executor=1to allow user disable this feature and fallback to query executor on runtimeTests
Type of change
This change is