Skip to content

Conversation

@dqhl76
Copy link
Collaborator

@dqhl76 dqhl76 commented Jul 1, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • chore: Remove compile flag enable_queries_executor
  • chore: Add a configuration [query.enable_queries_executor] to allow enable this feature
  • chore: Add a settings set disable_queries_executor=1 to allow user disable this feature and fallback to query executor on runtime
  • fix: queries executor hang due to thread blocking

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - No logic change

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Jul 1, 2025
@dqhl76 dqhl76 changed the title refactor: make queries executor lazy init refactor(executor): make queries executor lazy init Jul 1, 2025
@dqhl76 dqhl76 added the ci-benchmark Benchmark: run all test label Jul 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

Docker Image for PR

  • tag: pr-18283-95d9985-1751508291

note: this image tag is only available for internal use.

@dqhl76 dqhl76 changed the title refactor(executor): make queries executor lazy init refactor(executor): control queries executor via configuration Jul 3, 2025
@dqhl76 dqhl76 marked this pull request as ready for review July 3, 2025 05:32
@dqhl76 dqhl76 requested a review from zhang2014 July 3, 2025 05:32
@dqhl76
Copy link
Collaborator Author

dqhl76 commented Jul 3, 2025

Behaviour:

Enable in configuration:
Allow use set to disable it by

set use_legacy_query_executor = 1;

Allow revert by unset:

unset use_legacy_query_executor;

Allow use set to disable it by

set use_legacy_query_executor = 0;
error: APIError: QueryFailed: [2004]This setting is not allowed set to 0, please use unset

Not enable in configuration(default):

set use_legacy_query_executor = 1;
error: APIError: QueryFailed: [2004]This setting is not allowed when queries executor is not enabled in the config

@zhang2014 zhang2014 merged commit 316bafb into databendlabs:main Jul 4, 2025
86 checks passed
@dqhl76 dqhl76 deleted the queries-executor-refactor1 branch July 7, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-benchmark Benchmark: run all test pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants