refactor(query): prevent masking/row access policy name conflicts

[TCeason]

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

prevent masking/row access policy name conflicts

Tests

• Unit Test
• Logic Test
• Benchmark Test
• No Test - Explain why

Type of change

• Bug Fix (non-breaking change which fixes an issue)
• New Feature (non-breaking change which adds functionality)
• Breaking Change (fix or feature that could cause existing functionality not to work as expected)
• Documentation Update
• Refactoring
• Performance Improvement
• Other (please describe):

---

This change is 

[drmingdrmer]

@drmingdrmer reviewed 2 of 4 files at r1, all commit messages.
Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions

---

src/meta/api/src/data_mask_api_impl.rs line 105 at r1 (raw file):

                )
                .into());
            }

This function looks strange:

• fetch_id can be moved out from the transaction-retry-loop
• it does not need a loop to retry: just one transaction trial would be enough.

Code quote:

            let row_access_name_ident = RowAccessPolicyNameIdent::new(
                name_ident.tenant().clone(),
                name_ident.data_mask_name().to_string(),
            );
            if self.get_pb(&row_access_name_ident).await?.is_some() {
                return Err(AppError::DatamaskAlreadyExists(
                    name_ident.exist_error("name conflicts with an existing row access policy"),
                )
                .into());
            }

---

src/meta/api/src/data_mask_api_impl.rs line 112 at r1 (raw file):

            // data mask name -> data mask table id list

            let id = fetch_id(self, IdGenerator::data_mask_id()).await?;

fetch_id can be moved out from the transaction-retry-loop.

[TCeason]

Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on @drmingdrmer)

---

src/meta/api/src/data_mask_api_impl.rs line 105 at r1 (raw file):

Previously, drmingdrmer (张炎泼) wrote…

This function looks strange:

• fetch_id can be moved out from the transaction-retry-loop
• it does not need a loop to retry: just one transaction trial would be enough.

Done.

---

src/meta/api/src/data_mask_api_impl.rs line 112 at r1 (raw file):

Previously, drmingdrmer (张炎泼) wrote…

fetch_id can be moved out from the transaction-retry-loop.

Done.

[github-actions]

🤖 CI Job Analysis

Workflow: 19219571781

⛔️ CANCELLED

Higher priority request detected - retry cancelled to avoid conflicts.

View Workflow