Skip to content

Conversation

@cramorr-op
Copy link
Contributor

Pull Request

Pull Request (PR) description

Added a format placeholder when the URL is generated in Update-FabricSemanticModelDefinition.

Fixed

  • Fixed bug in Update-FabricSemanticModelDefinition - Uri was incorrect when a platform file exists

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency -Tasks build, test).
  • Comment-based help added/updated.
  • Examples appropriately added/updated.
  • Unit tests added/updated..
  • Integration tests added/updated (where possible).
  • Documentation added/updated (where applicable).
  • Code follows the contribution guidelines.

Added a placeholder in format statement currently an invalid URL is generated.
Added a fix description to the changelog
Copy link
Contributor

@NowinskiK NowinskiK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! All looks good.

@NowinskiK NowinskiK merged commit 1f6fe5b into dataplat:develop Sep 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants