-
Notifications
You must be signed in to change notification settings - Fork 15
Add Service Principal parameters for authentication #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Enhanced the Connect-FabricAccount function by adding support for Service Principal authentication. This includes new parameters for ServicePrincipalId, ServicePrincipalSecret, and Credential, allowing for more flexible authentication options. Updated the unit tests to reflect these changes and ensure proper validation. Thank you!
Linux Test Results4 617 tests 4 616 ✅ 43s ⏱️ Results for commit bdc0836. ♻️ This comment has been updated with latest results. |
WinPS51 Test Results4 617 tests 4 616 ✅ 55s ⏱️ Results for commit bdc0836. ♻️ This comment has been updated with latest results. |
WinPS71 Test Results4 617 tests 4 616 ✅ 51s ⏱️ Results for commit bdc0836. ♻️ This comment has been updated with latest results. |
|
@jpomfret @SQLDBAWithABeard can you help me with a PR approval? |
|
@Jojobit - yeah!! Nice add 🙂 - added a couple of comments, where possible I made suggestions so should make it easy for you to add them in if you're happy |
Co-authored-by: Jess Pomfret <[email protected]> Signed-off-by: Ioana Bouariu <[email protected]>
Co-authored-by: Jess Pomfret <[email protected]> Signed-off-by: Ioana Bouariu <[email protected]>
Co-authored-by: Jess Pomfret <[email protected]> Signed-off-by: Ioana Bouariu <[email protected]>
Co-authored-by: Jess Pomfret <[email protected]> Signed-off-by: Ioana Bouariu <[email protected]>
|
Happy to make the changes for you @Jojobit - If you would like. Thank you, this is awesome, so good to see all of your hard work coming to fruition here and thank you for creating the first PR of the next round !! |
|
@jpomfret @SQLDBAWithABeard feel free |
Signed-off-by: Rob Sewell <[email protected]>
Signed-off-by: Rob Sewell <[email protected]>
Signed-off-by: Rob Sewell <[email protected]>
Signed-off-by: Rob Sewell <[email protected]>
Enhanced the Connect-FabricAccount function by adding support for Service Principal authentication. This includes new parameters for ServicePrincipalId, ServicePrincipalSecret, and Credential, allowing for more flexible authentication options. Updated the unit tests to reflect these changes and ensure proper validation.
Thank you!
Pull Request
Added
Task list
build.ps1 -ResolveDependency).and comment-based help.