Sync-DbaLoginPassword - Add command to sync passwords using hashed values #9883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues This PR recreates and improves upon the functionality from closed PR #8985. Key additions: - New internal function Get-LoginPasswordHash.ps1 to extract password hashes - New public command Sync-DbaLoginPassword.ps1 to sync passwords between instances - Enhanced Set-DbaLogin.ps1 with -PasswordHash parameter for hash-based password setting - Comprehensive test coverage following dbatools patterns - Full documentation with usage examples The implementation uses Microsoft's sp_help_revlogin approach to extract and apply hashed password values, enabling password synchronization without knowing clear-text passwords. This is particularly useful for: - Maintaining consistent passwords across Availability Group replicas - Migrating logins between instances - Disaster recovery scenarios All code follows the dbatools style guide: - OTBS formatting throughout - Splat usage for 3+ parameters with descriptive names - Modern PowerShell syntax (no = $true in parameter attributes) - Hashtable alignment - Proper error handling with EnableException support Fixes #8980 Fixes #1032 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Chrissy LeMaire <[email protected]>
Member
Author
|
@claude we support psv3 too, pls add it not just to psd1 but psm1 for explicit export too |
|
Claude finished @potatoqualitee's task —— View job PSv3 Export Support Added ✓Completed Tasks
SummaryAdded The command is now properly exported in both:
--- | Branch |
Co-authored-by: Chrissy LeMaire <[email protected]>
Member
Author
|
@wsmelton pls review 🙏🏼 |
Member
Author
|
hell yeah thank you @ClaudioESSilva ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR recreates and improves upon the functionality from closed PR #8985.
Key Additions
Get-LoginPasswordHash.ps1to extract password hashesSync-DbaLoginPassword.ps1to sync passwords between instancesSet-DbaLogin.ps1with-PasswordHashparameter for hash-based password settingImplementation Details
The implementation uses Microsoft's sp_help_revlogin approach to extract and apply hashed password values, enabling password synchronization without knowing clear-text passwords.
Use Cases
Code Quality
All code follows the dbatools style guide:
= $truein parameter attributes)Fixes #8980
Fixes #1032
Closes #8985 (supersedes old PR)
🤖 Generated with Claude Code