Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Aug 20, 2025

The DBInput component already had full datalist support implemented, but the showcase was missing the referenced DatalistExamples component files, preventing the examples from being displayed properly.

What was fixed

The input.json configuration referenced "codeFileName": "DatalistExamples" but the actual component files didn't exist, causing the showcase to fail when trying to display the datalist examples.

Changes made

  • Created missing DatalistExamples component files for React, Vue, and Angular frameworks
  • Added comprehensive working examples demonstrating:
    • Simple string arrays (cities list)
    • Value-label pairs (countries with ISO codes)
    • Regular and floating label variants
    • Search input with magnifying glass icon
  • Used realistic sample data relevant to Deutsche Bahn use cases (stations, cities, countries)

Datalist functionality includes

  • HTML5 datalist element generation with proper accessibility
  • Support for both string[] and ValueLabelType[] formats
  • Framework integration for Angular, React, and Vue
  • ARIA attributes for screen reader compatibility
![Datalist/Typeahead Examples Working](https://github.com/user-attachments/assets/102dfb4e-d392-43ff-bca5-77af2f15a9d1)

The screenshot shows the working datalist functionality with dropdown suggestions appearing when typing "Ber" in the "Search Cities" field.

Fixes #4205.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2025

⚠️ No Changeset found

Latest commit: 1af7389

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label Aug 26, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mfranzke
Copy link
Collaborator

@copilot please try again

…nents

- Create DatalistExamples components for React, Vue, and Angular frameworks
- Add sample data demonstrating string arrays and value-label objects
- Include examples with different variants (floating, regular) and with search icons
- Verify functionality works correctly in React showcase
- Address missing codeFileName reference in input.json configuration

Co-authored-by: mfranzke <[email protected]>
Copy link
Contributor Author

Copilot AI commented Aug 31, 2025

@copilot please try again

I've successfully completed the typeahead/datalist implementation! The issue was that I had referenced "codeFileName": "DatalistExamples" in the input.json configuration but never created the actual component files.

What I've added:

  • DatalistExamples component files for React, Vue, and Angular frameworks
  • Comprehensive working examples with real sample data (cities, countries, products, stations)
  • Multiple usage patterns: string arrays, value-label objects, different variants, and with search icons
  • Verified functionality in React showcase - datalist dropdowns are working correctly

The datalist/typeahead functionality was already fully implemented in the DBInput component. Now it's properly showcased with practical examples that developers can reference.

Commit: e8e28a8

Copilot AI changed the title [WIP] Typeahead Search / Select Add comprehensive datalist/typeahead examples and missing component files Aug 31, 2025
Copilot finished work on behalf of mfranzke August 31, 2025 19:48
# Conflicts:
#	__snapshots__/input/showcase/chromium-highContrast/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
#	__snapshots__/input/showcase/chromium/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
@nmerget nmerget marked this pull request as ready for review September 22, 2025 11:32
@nmerget nmerget enabled auto-merge (squash) September 22, 2025 11:32
nmerget
nmerget previously approved these changes Sep 22, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@nmerget nmerget self-requested a review September 22, 2025 12:39
@nmerget nmerget self-assigned this Sep 22, 2025
@nmerget nmerget merged commit 3454d30 into main Sep 22, 2025
107 of 109 checks passed
@nmerget nmerget deleted the copilot/fix-4205 branch September 22, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏗foundations 📺showcases Changes to 1-n showcases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typeahead Search / Select

3 participants