feat: Switch stable rework #4861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tom select and input
…olor # Conflicts: # __snapshots__/textarea/showcase/chromium/DBTextarea-should-match-screenshot-1/DBTextarea-should-match-screenshot.png # __snapshots__/textarea/showcase/firefox/DBTextarea-should-match-screenshot-1/DBTextarea-should-match-screenshot.png # __snapshots__/textarea/showcase/mobile-chrome/DBTextarea-should-match-screenshot-1/DBTextarea-should-match-screenshot.png
…olor # Conflicts: # __snapshots__/textarea/showcase/mobile-chrome/DBTextarea-should-match-screenshot-1/DBTextarea-should-match-screenshot.png
🦋 Changeset detectedLatest commit: c199799 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/851-switch-stable |
nmerget
moved this from 🏗 In progress
to 🎁 Ready for review
in UX Engineering Team Backlog
Removed the `emphasis` property from the switch component and updated migration documentation.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mfranzke
reviewed
Oct 13, 2025
| [showMessage]="exampleProps?.showMessage" | ||
| [label]="exampleProps?.label" | ||
| >{{ | ||
| exampleProps?.label ? exampleProps?.label : exampleName |
Collaborator
There was a problem hiding this comment.
@nmerget those innerText differ from the other JS frameworks (showcases/vue-showcase/src/components/switch/Switch.vue and showcases/react-showcase/src/components/switch/index.tsx), is this intentionally?
github-project-automation
bot
moved this from 🎁 Ready for review
to ✅ Done
in UX Engineering Team Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
add accent stylingTypes of changes
Further comments
closes https://github.com/db-ux-design-system/core-team/issues/851
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/851-switch-stable