Skip to content

Fix publint.dev issues for @db-ux packages #4874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Fix publint.dev issues for @db-ux packages #4874

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
31483ae
Initial plan
Copilot Aug 31, 2025
655aaad
fix: resolve publint.dev issues for @db-ux packages
Copilot Aug 31, 2025
30710bb
Merge branch 'main' into copilot/fix-3912
mfranzke Sep 12, 2025
1a57676
Merge branch 'main' into copilot/fix-3912
mfranzke Sep 12, 2025
f1904a2
refactor: we need to additionally add this export
mfranzke Sep 12, 2025
0b00535
fix: react package files and exports
mfranzke Sep 12, 2025
c05649a
refactor: further export
mfranzke Sep 12, 2025
913bc59
Update package.json
mfranzke Sep 12, 2025
4ab1086
fix: corrected the path
mfranzke Sep 12, 2025
07164a8
refactor: adapted the file system reference approach by the other sho…
mfranzke Sep 12, 2025
ae2fa58
Merge branch 'main' into copilot/fix-3912
michaelmkraus Sep 16, 2025
e22da0f
Merge branch 'main' into copilot/fix-3912
michaelmkraus Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions output/angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
{
"name": "@db-ux/ngx-core-components",
"version": "0.0.0",
"type": "module",
"description": "Angular components @db-ux/core-components",
"repository": {
"type": "git",
"url": "git+https://github.com/db-ux-design-system/core-web.git"
},
"license": "Apache-2.0",
"main": "dist/fesm5.js",
"module": "dist/fesm5.js",
"types": "dist/core.d.ts",
"main": "fesm2022/db-ux-ngx-core-components.mjs",
"module": "fesm2022/db-ux-ngx-core-components.mjs",
"types": "index.d.ts",
Copy link
Contributor

@michaelmkraus michaelmkraus Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"types": "index.d.ts",
"types": "index.d.ts",
"exports": {
".": {
"types": "./dist/index.d.ts",
"default": "./dist/fesm2022/db-ux-angular-core-components.mjs"
},
"./styles/*": "./dist/styles/*"
}

Without export, we might still get warnings.

Copy link
Collaborator

@mfranzke mfranzke Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelmkraus should those folders actually actually include /dist/, as this folder level isn't included in the final package structure, compare to https://www.npmjs.com/package/@db-ux/ngx-core-components?activeTab=code ?

And what's the "./styles/*": "./dist/styles/*"declaration about? This is not included in the resulting node package.

"scripts": {
"build": "ng build",
"ng": "ng",
Expand Down
7 changes: 7 additions & 0 deletions output/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "@db-ux/react-core-components",
"version": "0.0.0",
"type": "module",
"description": "React components for @db-ux/core-components",
"repository": {
"type": "git",
Expand All @@ -13,6 +14,12 @@
"files": [
"dist/"
],
"exports": {
".": {
"types": "./dist/index.d.ts",
"default": "./dist/index.js"
}
},
"scripts": {
"build": "npm-run-all tsc",
"mv:dist": "cpr dist ../../build-outputs/react/dist --overwrite",
Expand Down
6 changes: 6 additions & 0 deletions packages/foundations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@
"assets",
"build"
],
"exports": {
".": {
"types": "./build/index.d.ts",
"default": "./build/index.js"
}
},
"scripts": {
"build": "npm-run-all build:*",
"build:01_normalize": "npm-run-all copy-prepare:*",
Expand Down
5 changes: 4 additions & 1 deletion packages/migration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,13 @@
"bin": {
"@db-ux/core-migration": "build/index.js"
},
"main": "build.js",
"main": "build/index.js",
"files": [
"build"
],
"exports": {
".": "./build/index.js"
},
"scripts": {
"build": "node esbuild.js",
"copy-build": "npm-run-all copy-build:*",
Expand Down
Loading