fix: DBTooltip race condition when component unmounts during delayed positioning #4984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DBTooltip component was failing with a TypeError when the tooltip element was removed from the DOM during the 1ms delay used for positioning. This race condition occurred in automated tests and fast user interactions.
Problem
When a tooltip trigger is hovered,
handleAutoPlacementis called with a 1ms delay to work around Angular-specific timing issues. However, if the component gets unmounted before this delay completes, the_refbecomes null, causinghandleFixedPopoverto fail:This typically happened in test scenarios where components were rapidly mounted and unmounted, but could also occur in real applications during fast user interactions.
Solution
Added a null check for
_refinside the delayed callback to prevent callinghandleFixedPopoverwith a null reference:Impact
The fix has been verified with manual testing showing tooltips continue to work correctly, and all existing tests pass.
Fixes #4400.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.