A11y-Update für DBSwitch #5624
Draft
A11y-Update für DBSwitch #5624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity in DBSwitch component
7 tasks
github-project-automation
bot
moved this to 🏗 In progress
in UX Engineering Team Backlog
|
sarahbrng
moved this from 🏗 In progress
to 🎁 Ready for review
in UX Engineering Team Backlog
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…n in Windows/NVDA
…bel and improve comment capitalization
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…nt label handling
…pplied-to-elements' of https://github.com/db-ux-design-system/core-web into 5495-changing-language-with-aria-labels-not-correctly-applied-to-elements
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Collaborator
|
@sarahbrng only making some of those |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…correctly-applied-to-elements
michaelmkraus
moved this from 🎁 Ready for review
to 👀 Actively In Review
in UX Engineering Team Backlog
…pplied-to-elements' of https://github.com/db-ux-design-system/core-web into 5495-changing-language-with-aria-labels-not-correctly-applied-to-elements
Comment on lines
+231
to
+232
| aria-label={props.ariaLabel} | ||
| aria-labelledby={props.ariaLabelledBy ?? state._labelId} |
Contributor
There was a problem hiding this comment.
According to the ARIA accessible name computation (W3C) and ARIA Authoring Practices, aria-labelledby takes precedence over aria-label. If both are present, aria-label is ignored.
So if aria-labelledby is present, wo do not need to set aria-label.
…correctly-applied-to-elements
michaelmkraus
moved this from 👀 Actively In Review
to 🎶 Waiting for feedback
in UX Engineering Team Backlog
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…pplied-to-elements' of https://github.com/db-ux-design-system/core-web into 5495-changing-language-with-aria-labels-not-correctly-applied-to-elements
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…pplied-to-elements' of https://github.com/db-ux-design-system/core-web into 5495-changing-language-with-aria-labels-not-correctly-applied-to-elements
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…licts The onMount hook in switch.lite.tsx was using state._id immediately after setting it to construct derived IDs (_labelId, _messageId, etc.). In React, this compiled to useState setters which don't update values synchronously, causing all derived IDs to be based on undefined/_id instead of the new ID value. This resulted in all switches on a page sharing the same broken label IDs, making screen readers announce the first switch's label for all switches. Fix: Use a local const variable to hold the ID value, ensuring all derived IDs are correctly constructed from the same value in a single pass. Fixes rendering bug introduced in commit 040e72a which added aria-labelledby support.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…licts The onMount hook in switch.lite.tsx was using state._id immediately after setting it to construct derived IDs (_labelId, _messageId, etc.). In React, this compiled to useState setters which don't update values synchronously, causing all derived IDs to be based on undefined/_id instead of the new ID value. This resulted in all switches on a page sharing the same broken label IDs, making screen readers announce the first switch's label for all switches. Fix: Use a local const variable to hold the ID value, ensuring all derived IDs are correctly constructed from the same value in a single pass. Fixes rendering bug introduced in commit 040e72a which added aria-labelledby support.
…pplied-to-elements' of https://github.com/db-ux-design-system/core-web into 5495-changing-language-with-aria-labels-not-correctly-applied-to-elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Das Problem: Bisher wurden ARIA-Labels beim Laden der Komponente einmalig gesetzt ("Snapshotted"). Bei dynamischen Änderungen zur Laufzeit (z. B. Sprachwechsel via i18n) blieb der Screenreader-Text veraltet.
Die Lösung: Die Inputs ariaLabel und ariaLabelledBy sind nun reaktive Props somit werden Änderungen sofort an das innere
input[type="checkbox"]weitergegeben. Der Accessible Name ist immer live aktuell.aria-labelbindet anariaLabel.aria-labelledbybindet anariaLabelledBy.resolves #5495
Types of changes
Further comments
🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/5495-changing-language-with-aria-labels-not-correctly-applied-to-elements