Skip to content

Conversation

@sergeyteleshev
Copy link
Contributor

Copy link
Contributor

@SychevAndrey SychevAndrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we don't need to pass the title as a prop here and could just use
import { useTranslate } from '@dbeaver/react-translate';
inside OrderButton

Please, check.

@sergeyteleshev
Copy link
Contributor Author

Maybe we don't need to pass the title as a prop here and could just use import { useTranslate } from '@dbeaver/react-translate'; inside OrderButton

Please, check.

This feature is present in 2 places. In one place, we want it. But in another we don't cause we don't have this functionality there

@Wroud
Copy link
Member

Wroud commented Nov 21, 2025

I also don't like the idea of adding props for translation. Let's move this ticket to the next tech sprint and discuss a possible solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants