Skip to content

fix: Make experimental Agent compatible with Haystack main and Haystack 2.19 #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2025
Merged

fix: Make experimental Agent compatible with Haystack main and Haystack 2.19 #393

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f204a14
Make experimental Agent compatible with Haystack main and Haystack 2.19
sjrl Oct 31, 2025
69599a2
Fix linting
sjrl Oct 31, 2025
f7d5eab
Add dev comment
sjrl Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions haystack_experimental/components/agents/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# pylint: disable=wrong-import-order,wrong-import-position,ungrouped-imports
# ruff: noqa: I001

import inspect
from dataclasses import dataclass
from typing import Any, Optional, Union

Expand Down Expand Up @@ -285,7 +286,10 @@ def run( # noqa: PLR0915
"snapshot": snapshot,
**kwargs,
}
self._runtime_checks(break_point=break_point, snapshot=snapshot)
if len(inspect.signature(self._runtime_checks).parameters) == 2:
self._runtime_checks(break_point, snapshot)
else:
self._runtime_checks(break_point) # type: ignore[call-arg] # pylint: disable=no-value-for-parameter

if snapshot:
exe_context = self._initialize_from_snapshot(
Expand Down Expand Up @@ -472,7 +476,10 @@ async def run_async(
"snapshot": snapshot,
**kwargs,
}
self._runtime_checks(break_point=break_point, snapshot=snapshot)
if len(inspect.signature(self._runtime_checks).parameters) == 2:
self._runtime_checks(break_point, snapshot)
else:
self._runtime_checks(break_point) # type: ignore[call-arg] # pylint: disable=no-value-for-parameter

if snapshot:
exe_context = self._initialize_from_snapshot(
Expand Down
Loading