Skip to content

Conversation

@sjrl
Copy link
Contributor

@sjrl sjrl commented Nov 17, 2025

Related Issues

Proposed Changes:

When creating a pipeline snapshot we make sure to use _deepcopy_with_exceptions when copying component inputs to avoid deep copies of items like components and tools since they often contain attributes that are not deep-copyable. For example, the LinkContentFetchter has httpx.Client as an attribute which throws an error if we try to deep copy it.

How did you test it?

Notes for the reviewer

Checklist

@sjrl sjrl requested a review from a team as a code owner November 17, 2025 09:37
@sjrl sjrl requested review from anakin87 and removed request for a team November 17, 2025 09:37
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sjrl sjrl merged commit ada7da2 into main Nov 17, 2025
5 of 6 checks passed
@sjrl sjrl deleted the use-deepcopy-with-exceptions branch November 17, 2025 10:28
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19425414790

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 71.356%

Files with Coverage Reduction New Missed Lines %
core/pipeline/breakpoint.py 6 54.55%
Totals Coverage Status
Change from base Build 19425407698: 0.0%
Covered Lines: 1126
Relevant Lines: 1578

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BreakpointConfirmationStrategy fails to serialize Components with thread locks

4 participants