Skip to content

Conversation

@sjrl
Copy link
Contributor

@sjrl sjrl commented Nov 17, 2025

Related Issues

  • fixes failing typing tests

Proposed Changes:

Update experimental Agent to also take in generation_kwargs that was added in this PR deepset-ai/haystack#9616 and released in Haystack 2.20.

The changes were made in such a way that both Haystack 2.19 and 2.20 should work with this version of experimental Agent.

How did you test it?

Tested using integration tests locally on version Haystack 2.20 and Haystack 2.19.0

Notes for the reviewer

Checklist

@sjrl sjrl requested a review from a team as a code owner November 17, 2025 09:55
@sjrl sjrl requested review from a team, anakin87 and mpangrazzi and removed request for a team November 17, 2025 09:55
@sjrl sjrl self-assigned this Nov 17, 2025
@sjrl
Copy link
Contributor Author

sjrl commented Nov 17, 2025

@anakin87 not finished testing yet, but wanted to show you the fix for the typing issues

Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sjrl sjrl merged commit ca87a12 into main Nov 17, 2025
8 checks passed
@sjrl sjrl deleted the fix-typing-issue-agent branch November 17, 2025 10:27
@coveralls
Copy link

coveralls commented Nov 17, 2025

Pull Request Test Coverage Report for Build 19425467759

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 92 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 71.176%

Files with Coverage Reduction New Missed Lines %
components/agents/agent.py 92 34.1%
Totals Coverage Status
Change from base Build 19425407698: -0.2%
Covered Lines: 1126
Relevant Lines: 1582

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 19425484473

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 92 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 71.176%

Files with Coverage Reduction New Missed Lines %
components/agents/agent.py 92 34.1%
Totals Coverage Status
Change from base Build 19425407698: -0.2%
Covered Lines: 1126
Relevant Lines: 1582

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 19425579784

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 92 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 71.176%

Files with Coverage Reduction New Missed Lines %
components/agents/agent.py 92 34.1%
Totals Coverage Status
Change from base Build 19425407698: -0.2%
Covered Lines: 1126
Relevant Lines: 1582

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants