draft: merge images and video to "gallery" tab #5644
Conversation
likely not the correct way, just for testing at this point.
r10s
left a comment
r10s
left a comment
There was a problem hiding this comment.
great stuff! it is working as expected.
cannot say much to the code, tho.
background: this PR came out of some discussions about streamlining the "all media" view across platforms, other PR at deltachat/deltachat-ios#2861 and deltachat/deltachat-android#3976
|
Sorry for interfering, but I think separating photos and videos into different tabs was an advantage. Especially for profiles with many pictures and videos. It's simply more organized, and users can find a specific video/image faster. Just because other messengers combine pictures and videos doesn't mean it's a good thing. Maybe a filter in the tab would be a good compromise? |
|
yip, a filter could do, but that is out of scope of this issue and would be a feature request. the PR it is about making delta chat UIs consistent, and the combine is a very small tradeoff, if at all. no larger amounts of user ever complained that android/ios should split their gallery - and an additional tab would also come at costs wrt usability. the cross checking of whatsapp/telegram/signal underlined the impression, we did not use that as a reason in the first place |
likely not the correct way (because of the extra callback, but maybe not as bad as I think?), just for testing at this point.
This is a pr so that r10s can test it, because I had not enough chats with videos.