fix: tauri: log core events in debug mode also to the logfile/console #5732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intercept jsonrpc responses to log core events in debug mode.
Simon-Laux
added
the
Runtime: Tauri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intercept jsonrpc responses to log core events in debug mode. To fix that log file was not logging the core events.
Made this in context of trying to debug chatmail/core#7270.
Also made chatmail/core#7459 for the cases where core was not using tracing simultaneously with emitting logging events (info, warn, info).
Those logging events look better than logging the events, because they don't spam the log with the exact file path and integrate better in the rust logging ecosystem that we also use in tauri.