Reduce react warnings #5770
Open
Reduce react warnings #5770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disabling the eslint rule for react-hooks/refs on places where it seems the warning is inappropriate
There is only a dependency on selectedChat.id so should be no bad side effect here
Member
Author
|
@WofWca we have 7 warnings just from the ChatlistContext file. Maybe you can have a look how to fix/avoid them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the number of warnings from 37 to 16. Many of the warnings seem inappropriate so just adding a line to disable the rook was often used.
Can be best reviewed commit by commit.