Fix/release scripts #135
Merged
Fix/release scripts #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation - Removed the action.yaml file for the require-changeset GitHub Action. - Introduced a new JavaScript script (require-changeset.js) to handle changeset validation. - Created a ChangesetRequirementService class to encapsulate changeset validation logic. - Added unit tests for the ChangesetRequirementService to ensure functionality. - Updated the CI workflow to use the new script instead of the action. - Enhanced utility classes (FSUtil, GitUtil, ShellUtil, PackageUtil) with additional methods and documentation.
Coverage Summary (2 packages)
|
💂♂️ CodeQL Security Scan 💂♂️Total alerts: 0 By severity (security_severity_level):
By result level:
|
- Deleted setup.js, fs.util.js, fs.util.test.js, git.util.js, git.util.test.js, package.util.js, package.util.test.js, shell.util.js, and shell.util.test.js as they are no longer needed. - Updated CI workflow to integrate new changeset validation and release steps. - Adjusted GitHub Actions to use new action implementations for changeset validation and release management.
deresegetachew
added
the
[skip changeset check]
…oved report generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors and modernizes the "Require Changeset" GitHub Action by replacing the previous Bash-based workflow with a modular, testable Node.js implementation. The changes introduce a service-oriented architecture, improved error handling, and comprehensive documentation for utility classes. The update also adds automated tests to ensure reliability and maintainability.
Require Changeset Action Refactor:
.github/actions/require-changeset/action.yamlis removed and replaced by a Node.js implementation using.github/scripts/require-changeset/require-changeset.jsand supporting modules. This allows for better modularity, error handling, and testability. [1] [2]Service Architecture & GitHub Integration:
ChangesetRequirementServicein.github/scripts/require-changeset/services/changeset-requirement.service.js, which encapsulates logic for validating changeset requirements, skipping checks for bots/releases/labels, and fetching changed files using multiple strategies for robustness. [1] [2]Testing and Reliability:
.github/scripts/require-changeset/require-changeset.test.jsusing Node.js test and mock APIs, verifying service exports and integration logic.Utility Class Improvements and Documentation:
FSUtil(.github/scripts/utils/fs.util.js) andPackageUtil(.github/scripts/utils/package.util.js), including detailed JSDoc comments and examples for all methods, improving developer experience and maintainability. [1] [2] [3] [4] [5]Robust Git Operations:
GitUtilnow supports multiple fallback strategies for detecting changed files between branches/commits, increasing reliability of the changeset check in various CI scenarios.