-
Notifications
You must be signed in to change notification settings - Fork 5
Fix metadata for PostContent #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
- Coverage 86.67% 86.00% -0.67%
==========================================
Files 23 23
Lines 2071 2108 +37
Branches 230 239 +9
==========================================
+ Hits 1795 1813 +18
- Misses 183 196 +13
- Partials 93 99 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- new svglib version (1.6.0) now requires cairo to be installed -> see deeplook/svglib#413
- _metadata-attribute on Post itself was wrong -> the meta didn't work there because it was fetched from PostContent => so most data was None / not set
|
I can of course also provide different PRs if needed - since the changes provided are 2 separate fixes and 1 (little) feature. |
|
Added another 2 fixes for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wfehr Thanks so much! Great work!
Can I ask you a few things:
- Can you please remove the Cairo change - elsewhere I have added svglib!=1.6.0 to the test setup ?
- Can you undo the changes in the djangocms_blog folder - it is only needed for migration purposes.
- If at all possible, I would appreciate some basic tests for the new PostContent methods...
These changes provide 3 things:
svglig<1.6.0for tests_metadata-attribute still remained in Post instead of PostContent[og|schemaorg|twitter]_title-attributes for Category/PostContent in_metadataand added checks in tests for thatmeta.tag(PostContent) andmeta.locale(PostContent + PostCategory)Tests are running successfully with these changes: https://github.com/wfehr/djangocms-stories/actions/runs/18707460615