Skip to content

Bootstrap4 Beta fixes based on using dev for django-crispy-forms #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Bootstrap4 Beta fixes based on using dev for django-crispy-forms #4

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d84df6
FormActions seems to need fixing
zoidyzoidzoid Jan 14, 2018
cbcf5be
Simplify horizontal form for upstream changes
zoidyzoidzoid Jan 15, 2018
d9e7419
Horizontal forms are a lot simpler now
zoidyzoidzoid Jan 15, 2018
79d3a1d
Merge branch 'master' into bootstrap4-beta
zoidyzoidzoid Oct 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions bootstrap4/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,12 @@ class MessageForm(forms.Form):
'multicolon_select',
'boolean_field',
'file_field',
FormActions(
Submit('save_changes', 'Save changes', css_class="btn-primary"),
Submit('cancel', 'Cancel'),
Div(
Div(
Submit('save_changes', 'Save changes', css_class="btn-primary"),
Submit('cancel', 'Cancel'),
),
css_class='form-group'
)
)

Expand Down Expand Up @@ -150,10 +153,6 @@ class HorizontalMessageForm(forms.Form):

multicolon_select = forms.MultipleChoiceField(
choices=(('1', '1'), ('2', '2'), ('3', '3'), ('4', '4'), ('5', '5')),
help_text=(
'This strange option climbing out of the box is in the examples too '
'Only without Flexbox '
'https://v4-alpha.getbootstrap.com/components/forms/#form-controls'),
)

boolean_field = forms.BooleanField()
Expand Down Expand Up @@ -186,5 +185,7 @@ class HorizontalMessageForm(forms.Form):
)
helper.form_group_wrapper_class = 'row'

helper.label_class = 'col-4'
helper.field_class = 'col-8'
helper.form_class = 'form-horizontal'
helper.label_class = 'col-sm-4'
helper.field_class = 'col-sm-8'