fix: use world space vectors for snow #1618
Open
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix snow appearing on vertical surfaces facing certain directions
Snow projection was comparing model-space and world-space vectors directly, causing inconsistent results based on
object rotation. Some wall-mounted objects (like rugs) would incorrectly show snow depending on which compass
direction they faced.
Fixed by transforming the projection direction to world space before the comparison.
Easiest way I found to replicate this was to download https://www.nexusmods.com/skyrimspecialedition/mods/18223 and create a new character, speedrun into the house and look at the rug facing the east.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.