Skip to content

Conversation

@wadepickett
Copy link
Contributor

@wadepickett wadepickett commented Nov 17, 2025

Fixes #36360

This is a follow up to PR #36355. There were commented out lines regarding a notice of pre-release that inteneded to be used later when the enxt pre-relase comes along, and while those commented out lines do not show in the build review, they do for some reason in the build for live.

The issue has been identified before as a problem with ::: that get read anyway during the process even when commented out per guardrex. So I removed any occurance of ::: witin the commented out lines.

@wadepickett
Copy link
Contributor Author

wadepickett commented Nov 17, 2025

Verified proper display on review build:
.NET 10 = No note.
image

.NET 9 = Note that it is not the latest
image

.NET 8 = Note that it is not the latest
image

@wadepickett wadepickett marked this pull request as ready for review November 17, 2025 17:37
@wadepickett wadepickett requested a review from Copilot November 17, 2025 17:37
Copilot finished reviewing on behalf of wadepickett November 17, 2025 17:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes commented-out HTML comment blocks from two include files that were unintentionally appearing in the live build. The blocks contained pre-release notices intended for future .NET 11 preview versions.

Key Changes

  • Removed commented-out pre-release notice blocks from version warning include files
  • Cleaned up HTML comments that were appearing in live builds unexpectedly

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
aspnetcore/includes/not-latest-version.md Removed commented-out .NET 11 pre-release notice block
aspnetcore/includes/not-latest-version-without-not-supported-content.md Removed commented-out .NET 11 pre-release notice block

@wadepickett
Copy link
Contributor Author

wadepickett commented Nov 17, 2025

I put the commented-out text, back in but removed the ::: as recommended by @guardrex

Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OOF and looking at the phone. If there are no moniker collision warnings on the build report, LGTM.

@wadepickett wadepickett merged commit af8896f into main Nov 17, 2025
4 checks passed
@wadepickett wadepickett deleted the wadepickett/36360RemoveNotLatestNote branch November 17, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

notice of pre-release

3 participants