-
Notifications
You must be signed in to change notification settings - Fork 25.1k
RemoveNotice of Pre-release #36364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RemoveNotice of Pre-release #36364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes commented-out HTML comment blocks from two include files that were unintentionally appearing in the live build. The blocks contained pre-release notices intended for future .NET 11 preview versions.
Key Changes
- Removed commented-out pre-release notice blocks from version warning include files
- Cleaned up HTML comments that were appearing in live builds unexpectedly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| aspnetcore/includes/not-latest-version.md | Removed commented-out .NET 11 pre-release notice block |
| aspnetcore/includes/not-latest-version-without-not-supported-content.md | Removed commented-out .NET 11 pre-release notice block |
|
I put the commented-out text, back in but removed the |
guardrex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OOF and looking at the phone. If there are no moniker collision warnings on the build report, LGTM.



Fixes #36360
This is a follow up to PR #36355. There were commented out lines regarding a notice of pre-release that inteneded to be used later when the enxt pre-relase comes along, and while those commented out lines do not show in the build review, they do for some reason in the build for live.
The issue has been identified before as a problem with
:::that get read anyway during the process even when commented out per guardrex. So I removed any occurance of:::witin the commented out lines.