-
Notifications
You must be signed in to change notification settings - Fork 719
Filter to highest package version per channel in aspire add command #12553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
59a2643
Initial plan
Copilot 6f6f039
Filter package versions to show only highest per channel
Copilot bba4849
Add tests to validate package version filtering
Copilot 765c30a
Address code review comments with documentation and type safety impro…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,7 @@ | ||||||
| // Licensed to the .NET Foundation under one or more agreements. | ||||||
| // The .NET Foundation licenses this file to you under the MIT license. | ||||||
|
|
||||||
| using System.Collections; | ||||||
| using Aspire.Cli.Backchannel; | ||||||
| using Aspire.Cli.Interaction; | ||||||
| using Spectre.Console; | ||||||
|
|
@@ -14,6 +15,13 @@ internal sealed class TestConsoleInteractionService : IInteractionService | |||||
| public Action<string>? DisplayConsoleWriteLineMessage { get; set; } | ||||||
| public Func<string, bool, bool>? ConfirmCallback { get; set; } | ||||||
| public Action<string>? ShowStatusCallback { get; set; } | ||||||
|
|
||||||
| /// <summary> | ||||||
| /// Callback for capturing selection prompts in tests. Uses non-generic IEnumerable and object | ||||||
| /// to work with the generic PromptForSelectionAsync<T> method regardless of T's type. | ||||||
|
||||||
| /// to work with the generic PromptForSelectionAsync<T> method regardless of T's type. | |
| /// to work with the generic PromptForSelectionAsync<T> method regardless of T's type. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
FakeNuGetPackageCacheclass lacks XML documentation. Add a<summary>tag explaining it's a test fake that returns empty package lists for all operations.