Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 31, 2025

Addresses code review feedback on the Docker Compose deployment PR.

Test fixes:

  • Removed duplicate IResourceContainerImageBuilder service registration in DockerComposePublisherTests.cs that would cause DI container conflicts

Code simplification:

  • Refactored EnvFile.AddOrUpdate to eliminate duplicate assignment in if/else branches by checking onlyIfMissing condition upfront

Before:

if (_entries.ContainsKey(key))
{
    if (onlyIfMissing) return;
    _entries[key] = new EnvEntry(key, value, comment);
}
else
{
    _entries[key] = new EnvEntry(key, value, comment);  // Duplicate
}

After:

if (_entries.ContainsKey(key) && onlyIfMissing)
{
    return;
}
_entries[key] = new EnvEntry(key, value, comment);

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Add deploy support for Docker Compose Fix duplicate service registration and simplify EnvFile logic Oct 31, 2025
Copilot AI requested a review from captainsafia October 31, 2025 21:54
Copilot finished work on behalf of captainsafia October 31, 2025 21:54
@captainsafia captainsafia marked this pull request as ready for review October 31, 2025 22:21
@captainsafia captainsafia merged commit e8b791e into safia/dcd Oct 31, 2025
2 of 3 checks passed
@captainsafia captainsafia deleted the copilot/sub-pr-12548 branch October 31, 2025 22:21
captainsafia added a commit that referenced this pull request Nov 1, 2025
* Initial plan

* Address Copilot feedback: Remove duplicate registration and simplify EnvFile logic

Co-authored-by: captainsafia <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: captainsafia <[email protected]>
captainsafia added a commit that referenced this pull request Nov 1, 2025
* Add deploy support for Docker Compose

* Fix duplicate service registration and simplify EnvFile logic (#12575)

* Initial plan

* Address Copilot feedback: Remove duplicate registration and simplify EnvFile logic

Co-authored-by: captainsafia <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: captainsafia <[email protected]>

* Refine Docker Compose publishing: env file naming, log verbosity, and status messages (#12580)

* Initial plan

* Address PR feedback: Update env file naming, reduce log verbosity, and enhance success message

Co-authored-by: captainsafia <[email protected]>

* Fix log verbosity: Move completion message to Debug level instead of task creation

Co-authored-by: captainsafia <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: captainsafia <[email protected]>

* Fix passing of RIDs in dotnet publish for back-compat

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: captainsafia <[email protected]>
captainsafia added a commit that referenced this pull request Nov 3, 2025
* Add deploy support for Docker Compose

* Fix duplicate service registration and simplify EnvFile logic (#12575)

* Initial plan

* Address Copilot feedback: Remove duplicate registration and simplify EnvFile logic

Co-authored-by: captainsafia <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: captainsafia <[email protected]>

* Refine Docker Compose publishing: env file naming, log verbosity, and status messages (#12580)

* Initial plan

* Address PR feedback: Update env file naming, reduce log verbosity, and enhance success message

Co-authored-by: captainsafia <[email protected]>

* Fix log verbosity: Move completion message to Debug level instead of task creation

Co-authored-by: captainsafia <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: captainsafia <[email protected]>

* Fix passing of RIDs in dotnet publish for back-compat

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: captainsafia <[email protected]>
captainsafia added a commit that referenced this pull request Nov 3, 2025
* Add deploy support for Docker Compose (#12548)

* Add deploy support for Docker Compose

* Fix duplicate service registration and simplify EnvFile logic (#12575)

* Initial plan

* Address Copilot feedback: Remove duplicate registration and simplify EnvFile logic

Co-authored-by: captainsafia <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: captainsafia <[email protected]>

* Refine Docker Compose publishing: env file naming, log verbosity, and status messages (#12580)

* Initial plan

* Address PR feedback: Update env file naming, reduce log verbosity, and enhance success message

Co-authored-by: captainsafia <[email protected]>

* Fix log verbosity: Move completion message to Debug level instead of task creation

Co-authored-by: captainsafia <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: captainsafia <[email protected]>

* Fix passing of RIDs in dotnet publish for back-compat

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: captainsafia <[email protected]>

* Replace ContainerTargetPlatform.AllLinux with LinuxAmd64 (#12596)

* Initial plan

* Update ContainerTargetPlatform from AllLinux to LinuxAmd64

- Replace ContainerTargetPlatform.AllLinux with LinuxAmd64 in ProjectResource.cs (2 occurrences)
- Replace ContainerTargetPlatform.AllLinux with LinuxAmd64 in ContainerResourceBuilderExtensions.cs
- Remove AllLinux enum value from ContainerTargetPlatform enum definition

Co-authored-by: captainsafia <[email protected]>

* Completed: Update ContainerTargetPlatform from AllLinux to LinuxAmd64

Co-authored-by: captainsafia <[email protected]>

* Restore AllLinux enum and revert unintended template changes

- Restore the AllLinux enum value in ContainerTargetPlatform
- Revert all unintended changes to Aspire.ProjectTemplates localization files

Co-authored-by: davidfowl <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: captainsafia <[email protected]>
Co-authored-by: davidfowl <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: captainsafia <[email protected]>
Co-authored-by: davidfowl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants