-
Notifications
You must be signed in to change notification settings - Fork 736
Fix duplicate service registration and simplify EnvFile logic #12575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EnvFile logic Co-authored-by: captainsafia <[email protected]>
Copilot
AI
changed the title
[WIP] Add deploy support for Docker Compose
Fix duplicate service registration and simplify EnvFile logic
Oct 31, 2025
Copilot finished work on behalf of
captainsafia
October 31, 2025 21:54
captainsafia
added a commit
that referenced
this pull request
Nov 1, 2025
* Initial plan * Address Copilot feedback: Remove duplicate registration and simplify EnvFile logic Co-authored-by: captainsafia <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: captainsafia <[email protected]>
captainsafia
added a commit
that referenced
this pull request
Nov 1, 2025
* Add deploy support for Docker Compose * Fix duplicate service registration and simplify EnvFile logic (#12575) * Initial plan * Address Copilot feedback: Remove duplicate registration and simplify EnvFile logic Co-authored-by: captainsafia <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: captainsafia <[email protected]> * Refine Docker Compose publishing: env file naming, log verbosity, and status messages (#12580) * Initial plan * Address PR feedback: Update env file naming, reduce log verbosity, and enhance success message Co-authored-by: captainsafia <[email protected]> * Fix log verbosity: Move completion message to Debug level instead of task creation Co-authored-by: captainsafia <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: captainsafia <[email protected]> * Fix passing of RIDs in dotnet publish for back-compat --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: captainsafia <[email protected]>
captainsafia
added a commit
that referenced
this pull request
Nov 3, 2025
* Add deploy support for Docker Compose * Fix duplicate service registration and simplify EnvFile logic (#12575) * Initial plan * Address Copilot feedback: Remove duplicate registration and simplify EnvFile logic Co-authored-by: captainsafia <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: captainsafia <[email protected]> * Refine Docker Compose publishing: env file naming, log verbosity, and status messages (#12580) * Initial plan * Address PR feedback: Update env file naming, reduce log verbosity, and enhance success message Co-authored-by: captainsafia <[email protected]> * Fix log verbosity: Move completion message to Debug level instead of task creation Co-authored-by: captainsafia <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: captainsafia <[email protected]> * Fix passing of RIDs in dotnet publish for back-compat --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: captainsafia <[email protected]>
captainsafia
added a commit
that referenced
this pull request
Nov 3, 2025
* Add deploy support for Docker Compose (#12548) * Add deploy support for Docker Compose * Fix duplicate service registration and simplify EnvFile logic (#12575) * Initial plan * Address Copilot feedback: Remove duplicate registration and simplify EnvFile logic Co-authored-by: captainsafia <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: captainsafia <[email protected]> * Refine Docker Compose publishing: env file naming, log verbosity, and status messages (#12580) * Initial plan * Address PR feedback: Update env file naming, reduce log verbosity, and enhance success message Co-authored-by: captainsafia <[email protected]> * Fix log verbosity: Move completion message to Debug level instead of task creation Co-authored-by: captainsafia <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: captainsafia <[email protected]> * Fix passing of RIDs in dotnet publish for back-compat --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: captainsafia <[email protected]> * Replace ContainerTargetPlatform.AllLinux with LinuxAmd64 (#12596) * Initial plan * Update ContainerTargetPlatform from AllLinux to LinuxAmd64 - Replace ContainerTargetPlatform.AllLinux with LinuxAmd64 in ProjectResource.cs (2 occurrences) - Replace ContainerTargetPlatform.AllLinux with LinuxAmd64 in ContainerResourceBuilderExtensions.cs - Remove AllLinux enum value from ContainerTargetPlatform enum definition Co-authored-by: captainsafia <[email protected]> * Completed: Update ContainerTargetPlatform from AllLinux to LinuxAmd64 Co-authored-by: captainsafia <[email protected]> * Restore AllLinux enum and revert unintended template changes - Restore the AllLinux enum value in ContainerTargetPlatform - Revert all unintended changes to Aspire.ProjectTemplates localization files Co-authored-by: davidfowl <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: captainsafia <[email protected]> Co-authored-by: davidfowl <[email protected]> --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: captainsafia <[email protected]> Co-authored-by: davidfowl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback on the Docker Compose deployment PR.
Test fixes:
IResourceContainerImageBuilderservice registration inDockerComposePublisherTests.csthat would cause DI container conflictsCode simplification:
EnvFile.AddOrUpdateto eliminate duplicate assignment in if/else branches by checkingonlyIfMissingcondition upfrontBefore:
After:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.