-
Notifications
You must be signed in to change notification settings - Fork 736
Refine Docker Compose publishing: env file naming, log verbosity, and status messages #12580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d enhance success message Co-authored-by: captainsafia <[email protected]>
| } | ||
| } | ||
|
|
||
| reportingStep.Log(LogLevel.Debug, "Writing the Docker Compose file to the output path.", enableMarkdown: false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot This is not correct. Remove this and instead change the log level for the log over at
| logger.FinishGeneratingDockerCompose(OutputPath); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit b561785. Removed the incorrect Debug log and changed the FinishGeneratingDockerCompose logger method from LogLevel.Information to LogLevel.Debug to reduce duplicate Info-level logs.
…task creation Co-authored-by: captainsafia <[email protected]>
… status messages (#12580) * Initial plan * Address PR feedback: Update env file naming, reduce log verbosity, and enhance success message Co-authored-by: captainsafia <[email protected]> * Fix log verbosity: Move completion message to Debug level instead of task creation Co-authored-by: captainsafia <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: captainsafia <[email protected]>
* Add deploy support for Docker Compose * Fix duplicate service registration and simplify EnvFile logic (#12575) * Initial plan * Address Copilot feedback: Remove duplicate registration and simplify EnvFile logic Co-authored-by: captainsafia <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: captainsafia <[email protected]> * Refine Docker Compose publishing: env file naming, log verbosity, and status messages (#12580) * Initial plan * Address PR feedback: Update env file naming, reduce log verbosity, and enhance success message Co-authored-by: captainsafia <[email protected]> * Fix log verbosity: Move completion message to Debug level instead of task creation Co-authored-by: captainsafia <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: captainsafia <[email protected]> * Fix passing of RIDs in dotnet publish for back-compat --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: captainsafia <[email protected]>
* Add deploy support for Docker Compose * Fix duplicate service registration and simplify EnvFile logic (#12575) * Initial plan * Address Copilot feedback: Remove duplicate registration and simplify EnvFile logic Co-authored-by: captainsafia <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: captainsafia <[email protected]> * Refine Docker Compose publishing: env file naming, log verbosity, and status messages (#12580) * Initial plan * Address PR feedback: Update env file naming, reduce log verbosity, and enhance success message Co-authored-by: captainsafia <[email protected]> * Fix log verbosity: Move completion message to Debug level instead of task creation Co-authored-by: captainsafia <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: captainsafia <[email protected]> * Fix passing of RIDs in dotnet publish for back-compat --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: captainsafia <[email protected]>
* Add deploy support for Docker Compose (#12548) * Add deploy support for Docker Compose * Fix duplicate service registration and simplify EnvFile logic (#12575) * Initial plan * Address Copilot feedback: Remove duplicate registration and simplify EnvFile logic Co-authored-by: captainsafia <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: captainsafia <[email protected]> * Refine Docker Compose publishing: env file naming, log verbosity, and status messages (#12580) * Initial plan * Address PR feedback: Update env file naming, reduce log verbosity, and enhance success message Co-authored-by: captainsafia <[email protected]> * Fix log verbosity: Move completion message to Debug level instead of task creation Co-authored-by: captainsafia <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: captainsafia <[email protected]> * Fix passing of RIDs in dotnet publish for back-compat --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: captainsafia <[email protected]> * Replace ContainerTargetPlatform.AllLinux with LinuxAmd64 (#12596) * Initial plan * Update ContainerTargetPlatform from AllLinux to LinuxAmd64 - Replace ContainerTargetPlatform.AllLinux with LinuxAmd64 in ProjectResource.cs (2 occurrences) - Replace ContainerTargetPlatform.AllLinux with LinuxAmd64 in ContainerResourceBuilderExtensions.cs - Remove AllLinux enum value from ContainerTargetPlatform enum definition Co-authored-by: captainsafia <[email protected]> * Completed: Update ContainerTargetPlatform from AllLinux to LinuxAmd64 Co-authored-by: captainsafia <[email protected]> * Restore AllLinux enum and revert unintended template changes - Restore the AllLinux enum value in ContainerTargetPlatform - Revert all unintended changes to Aspire.ProjectTemplates localization files Co-authored-by: davidfowl <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: captainsafia <[email protected]> Co-authored-by: davidfowl <[email protected]> --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: captainsafia <[email protected]> Co-authored-by: davidfowl <[email protected]>
Addresses feedback on Docker Compose publishing to improve conventions, reduce log noise, and clarify deployment status.
Environment file naming
{environmentName}.envto.env.{environmentName}to follow dotenv conventionsGetEnvFilePath()inDockerComposeEnvironmentResourceand corresponding test assertionsLog verbosity reduction
FinishGeneratingDockerComposelogger method fromLogLevel.InformationtoLogLevel.DebugEnhanced deployment status
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.