Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 31, 2025

Addresses feedback on Docker Compose publishing to improve conventions, reduce log noise, and clarify deployment status.

Environment file naming

  • Changed from {environmentName}.env to .env.{environmentName} to follow dotenv conventions
  • Updated GetEnvFilePath() in DockerComposeEnvironmentResource and corresponding test assertions

Log verbosity reduction

  • Changed FinishGeneratingDockerCompose logger method from LogLevel.Information to LogLevel.Debug
  • Eliminates duplicate Info-level logging of "Successfully generated Compose output in '...'" message during publish step

Enhanced deployment status

  • Updated docker-compose-up success message from "Docker Compose deployment complete for {Name}" to "Service {Name} is now running with Docker Compose locally"
  • Provides clearer indication that the service is running in local Docker Compose environment

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…d enhance success message

Co-authored-by: captainsafia <[email protected]>
Copilot AI changed the title [WIP] Add deploy support for Docker Compose Refine Docker Compose publishing: env file naming, log verbosity, and status messages Oct 31, 2025
Copilot finished work on behalf of captainsafia October 31, 2025 23:36
Copilot AI requested a review from captainsafia October 31, 2025 23:36
}
}

reportingStep.Log(LogLevel.Debug, "Writing the Docker Compose file to the output path.", enableMarkdown: false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot This is not correct. Remove this and instead change the log level for the log over at

logger.FinishGeneratingDockerCompose(OutputPath);
.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit b561785. Removed the incorrect Debug log and changed the FinishGeneratingDockerCompose logger method from LogLevel.Information to LogLevel.Debug to reduce duplicate Info-level logs.

Copilot AI requested a review from captainsafia November 1, 2025 00:10
Copilot finished work on behalf of captainsafia November 1, 2025 00:10
@captainsafia captainsafia marked this pull request as ready for review November 1, 2025 00:17
@captainsafia captainsafia merged commit cf4bb7e into safia/dcd Nov 1, 2025
2 of 3 checks passed
@captainsafia captainsafia deleted the copilot/sub-pr-12548 branch November 1, 2025 00:17
captainsafia added a commit that referenced this pull request Nov 1, 2025
… status messages (#12580)

* Initial plan

* Address PR feedback: Update env file naming, reduce log verbosity, and enhance success message

Co-authored-by: captainsafia <[email protected]>

* Fix log verbosity: Move completion message to Debug level instead of task creation

Co-authored-by: captainsafia <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: captainsafia <[email protected]>
captainsafia added a commit that referenced this pull request Nov 1, 2025
* Add deploy support for Docker Compose

* Fix duplicate service registration and simplify EnvFile logic (#12575)

* Initial plan

* Address Copilot feedback: Remove duplicate registration and simplify EnvFile logic

Co-authored-by: captainsafia <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: captainsafia <[email protected]>

* Refine Docker Compose publishing: env file naming, log verbosity, and status messages (#12580)

* Initial plan

* Address PR feedback: Update env file naming, reduce log verbosity, and enhance success message

Co-authored-by: captainsafia <[email protected]>

* Fix log verbosity: Move completion message to Debug level instead of task creation

Co-authored-by: captainsafia <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: captainsafia <[email protected]>

* Fix passing of RIDs in dotnet publish for back-compat

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: captainsafia <[email protected]>
captainsafia added a commit that referenced this pull request Nov 3, 2025
* Add deploy support for Docker Compose

* Fix duplicate service registration and simplify EnvFile logic (#12575)

* Initial plan

* Address Copilot feedback: Remove duplicate registration and simplify EnvFile logic

Co-authored-by: captainsafia <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: captainsafia <[email protected]>

* Refine Docker Compose publishing: env file naming, log verbosity, and status messages (#12580)

* Initial plan

* Address PR feedback: Update env file naming, reduce log verbosity, and enhance success message

Co-authored-by: captainsafia <[email protected]>

* Fix log verbosity: Move completion message to Debug level instead of task creation

Co-authored-by: captainsafia <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: captainsafia <[email protected]>

* Fix passing of RIDs in dotnet publish for back-compat

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: captainsafia <[email protected]>
captainsafia added a commit that referenced this pull request Nov 3, 2025
* Add deploy support for Docker Compose (#12548)

* Add deploy support for Docker Compose

* Fix duplicate service registration and simplify EnvFile logic (#12575)

* Initial plan

* Address Copilot feedback: Remove duplicate registration and simplify EnvFile logic

Co-authored-by: captainsafia <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: captainsafia <[email protected]>

* Refine Docker Compose publishing: env file naming, log verbosity, and status messages (#12580)

* Initial plan

* Address PR feedback: Update env file naming, reduce log verbosity, and enhance success message

Co-authored-by: captainsafia <[email protected]>

* Fix log verbosity: Move completion message to Debug level instead of task creation

Co-authored-by: captainsafia <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: captainsafia <[email protected]>

* Fix passing of RIDs in dotnet publish for back-compat

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: captainsafia <[email protected]>

* Replace ContainerTargetPlatform.AllLinux with LinuxAmd64 (#12596)

* Initial plan

* Update ContainerTargetPlatform from AllLinux to LinuxAmd64

- Replace ContainerTargetPlatform.AllLinux with LinuxAmd64 in ProjectResource.cs (2 occurrences)
- Replace ContainerTargetPlatform.AllLinux with LinuxAmd64 in ContainerResourceBuilderExtensions.cs
- Remove AllLinux enum value from ContainerTargetPlatform enum definition

Co-authored-by: captainsafia <[email protected]>

* Completed: Update ContainerTargetPlatform from AllLinux to LinuxAmd64

Co-authored-by: captainsafia <[email protected]>

* Restore AllLinux enum and revert unintended template changes

- Restore the AllLinux enum value in ContainerTargetPlatform
- Revert all unintended changes to Aspire.ProjectTemplates localization files

Co-authored-by: davidfowl <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: captainsafia <[email protected]>
Co-authored-by: davidfowl <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: captainsafia <[email protected]>
Co-authored-by: davidfowl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants