Refactor ACR authentication to use Azure SDK TokenCredential with OAuth2 token exchange

tests/Aspire.Hosting.Azure.Tests/AzureDeployerTests.cs

@@ -936,7 +936,7 @@ private static void ConfigureTestServices(IDistributedApplicationTestingBuilder
         builder.Services.AddSingleton<IProcessRunner>(processRunner ?? new MockProcessRunner());
         builder.Services.AddSingleton<IResourceContainerImageBuilder, MockImageBuilder>();
         builder.Services.AddSingleton<IContainerRuntime>(containerRuntime ?? new FakeContainerRuntime());
-        builder.Services.AddSingleton<IAcrLoginService, FakeAcrLoginService>();
+        builder.Services.AddSingleton<IAcrLoginService>(sp => new FakeAcrLoginService(sp.GetRequiredService<IContainerRuntime>()));
     }
 
     private sealed class NoOpDeploymentStateManager : IDeploymentStateManager
@@ -1179,7 +1179,7 @@ private static void ConfigureTestServicesWithFileDeploymentStateManager(
         builder.Services.AddSingleton<IProcessRunner>(new MockProcessRunner());
         builder.Services.AddSingleton<IResourceContainerImageBuilder, MockImageBuilder>();
         builder.Services.AddSingleton<IContainerRuntime>(new FakeContainerRuntime());
-        builder.Services.AddSingleton<IAcrLoginService, FakeAcrLoginService>();
+        builder.Services.AddSingleton<IAcrLoginService>(sp => new FakeAcrLoginService(sp.GetRequiredService<IContainerRuntime>()));
     }
 
     private sealed class TestPublishingActivityReporter : IPipelineActivityReporter

tests/Aspire.Hosting.Azure.Tests/FakeAcrLoginService.cs

@@ -1,17 +1,29 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+#pragma warning disable ASPIRECONTAINERRUNTIME001
+
+using Aspire.Hosting.Publishing;
 using Azure.Core;
 
 namespace Aspire.Hosting.Azure.Tests;
 
 internal sealed class FakeAcrLoginService : IAcrLoginService
 {
+    private const string AcrUsername = "00000000-0000-0000-0000-000000000000";
+
+    private readonly IContainerRuntime _containerRuntime;
+
     public bool WasLoginCalled { get; private set; }
     public string? LastRegistryEndpoint { get; private set; }
     public string? LastTenantId { get; private set; }
 
-    public Task LoginAsync(
+    public FakeAcrLoginService(IContainerRuntime containerRuntime)
+    {
+        _containerRuntime = containerRuntime ?? throw new ArgumentNullException(nameof(containerRuntime));
+    }
+
+    public async Task LoginAsync(
         string registryEndpoint,
         string tenantId,
         TokenCredential credential,
@@ -20,6 +32,9 @@ public Task LoginAsync(
         WasLoginCalled = true;
         LastRegistryEndpoint = registryEndpoint;
         LastTenantId = tenantId;
-        return Task.CompletedTask;
+
+        // Call the container runtime to match real implementation behavior
+        // This allows tests to verify the container runtime was called
+        await _containerRuntime.LoginToRegistryAsync(registryEndpoint, AcrUsername, "fake-refresh-token", cancellationToken);
     }
 }